Skip to content

fix: Fix when enter over 8 decimal crash. #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keith-CY merged 2 commits into from
Apr 17, 2023
Merged

fix: Fix when enter over 8 decimal crash. #2629

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
880d020
fix: Fix when enter over 8 decimal crash.
yanguoyu Apr 10, 2023
b9b0e6a
docs: Add comment
yanguoyu Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/neuron-ui/src/components/NervosDAO/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,14 @@ const NervosDAO = () => {
}, [])

useEffect(() => {
if (BigInt(CKBToShannonFormatter(depositValue)) > maxDepositAmount) {
setDepositValue(shannonToCKBFormatter(`${maxDepositAmount}`, false, ''))
try {
if (BigInt(CKBToShannonFormatter(depositValue)) > maxDepositAmount) {
setDepositValue(shannonToCKBFormatter(`${maxDepositAmount}`, false, ''))
}
} catch (error) {
// ignore error
Comment thread
yanguoyu marked this conversation as resolved.
// When the depositValue is invalid, it displays the error in the textField, but it will throw an exception when valid wheater it's big than the max deposit value
// and when the depositValue is invalid, it's no need to set max depositValue.
}
}, [maxDepositAmount, depositValue, setDepositValue])

Expand Down