refactor(neuron-ui): refactor wallet setting #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Keith-CY
commented
Apr 23, 2019
Keith-CY
commented
- remove pagination in wallet setting
- add scroll list in wallet setting and network setting
- group hooks in wallet setting
1. remove pagination in wallet setting 2. add scroll list in wallet setting and network setting 3. group hooks in wallet setting
ashchan
reviewed
Apr 23, 2019
Contributor
|
Please check CI status |
Collaborator
Author
|
CI passed, and I found that the linter in CRA3.0 seems not to work well, maybe need more optimization. |
Contributor
Not surprising regarding the linting thing ;-) Can you take care of that? (but not urgent) |
ashchan
approved these changes
Apr 24, 2019
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
* chore(deps): update dependency lint-staged to v13.3.0 * chore(deps): update babel monorepo to v7.22.15 * chore(deps): update dependency @types/react to v17.0.65 * chore(deps): update dependency concurrently to v8.2.1 * chore(deps): update dependency webpack to v5.88.2 * chore(deps): update dependency @babel/core to v7.22.17 * chore(deps): update dependency @types/styled-components to v5.1.27 * chore(deps): update babel monorepo to v7.23.2 (#264) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.20.0 (#265) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/base to v0.20.0 (#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Chen Yu <keithwhisper@gmail.com> * chore(deps): update dependency @types/leveldown to v4.0.4 (#258) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/elliptic to v6.4.15 (#269) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/async to v3.2.21 (#267) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.