Skip to content

fix: failed to connect to ckb rpc after upgrading electron to v23#2652

Merged
Keith-CY merged 1 commit into
nervosnetwork:developfrom
WhiteMinds:fix/122_RPCConnectErrorOnElectron23
Apr 28, 2023
Merged

fix: failed to connect to ckb rpc after upgrading electron to v23#2652
Keith-CY merged 1 commit into
nervosnetwork:developfrom
WhiteMinds:fix/122_RPCConnectErrorOnElectron23

Conversation

@WhiteMinds
Copy link
Copy Markdown
Contributor

fix: failed to connect to ckb rpc after upgrading electron to v23

@yanguoyu
Copy link
Copy Markdown
Contributor

CI failed.

@WhiteMinds WhiteMinds force-pushed the fix/122_RPCConnectErrorOnElectron23 branch from 64a2553 to 1d273c2 Compare April 28, 2023 01:59
@WhiteMinds
Copy link
Copy Markdown
Contributor Author

CI failed.

Solved, I used src to filter the search results when processing before and forgot to have tests.

Comment thread packages/neuron-wallet/tests/services/node.test.ts
Comment thread packages/neuron-wallet/src/services/networks.ts
@WhiteMinds WhiteMinds force-pushed the fix/122_RPCConnectErrorOnElectron23 branch from 1d273c2 to 20da080 Compare April 28, 2023 07:24
@Keith-CY Keith-CY merged commit 0952040 into nervosnetwork:develop Apr 28, 2023
@WhiteMinds WhiteMinds deleted the fix/122_RPCConnectErrorOnElectron23 branch April 28, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants