Skip to content

Fix the current problematic ESLint and Prettier workflow#2662

Merged
Keith-CY merged 12 commits into
nervosnetwork:developfrom
WhiteMinds:fix/143_CodeStyle
May 16, 2023
Merged

Fix the current problematic ESLint and Prettier workflow#2662
Keith-CY merged 12 commits into
nervosnetwork:developfrom
WhiteMinds:fix/143_CodeStyle

Conversation

@WhiteMinds
Copy link
Copy Markdown
Contributor

Fix the current problematic ESLint and Prettier workflow

.createHmac('sha512', Buffer.from('Bitcoin seed', 'utf8'))
.update(seed)
.digest()
const i = crypto.createHmac('sha512', Buffer.from('Bitcoin seed', 'utf8')).update(seed).digest()

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bitcoin seed" is used as [key](1).
Comment thread packages/neuron-ui/.eslintrc.js Outdated
Comment thread packages/neuron-ui/.eslintrc.js
Comment thread packages/neuron-ui/src/components/History/hooks.ts
Comment thread packages/neuron-ui/src/components/WalletEditor/hooks.ts
Comment thread .vscode/extensions.json
Comment thread .vscode/settings.json
Comment thread packages/neuron-ui/.prettierrc.js
Comment thread packages/neuron-wallet/.prettierrc.js Outdated
@WhiteMinds WhiteMinds force-pushed the fix/143_CodeStyle branch 4 times, most recently from 23a2f78 to 66deb97 Compare May 16, 2023 04:09
@WhiteMinds WhiteMinds force-pushed the fix/143_CodeStyle branch from 66deb97 to a4b7433 Compare May 16, 2023 05:01
@WhiteMinds WhiteMinds force-pushed the fix/143_CodeStyle branch from a4b7433 to c76754f Compare May 16, 2023 05:14
@WhiteMinds
Copy link
Copy Markdown
Contributor Author

Rebased onto develop branch.

@Keith-CY Keith-CY merged commit 0367857 into nervosnetwork:develop May 16, 2023
@WhiteMinds WhiteMinds deleted the fix/143_CodeStyle branch May 26, 2023 07:28
@Keith-CY Keith-CY mentioned this pull request May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants