Skip to content

fix: Fix deposit dao#2663

Merged
Keith-CY merged 3 commits into
nervosnetwork:developfrom
yanguoyu:fix-deposite-dao
May 15, 2023
Merged

fix: Fix deposit dao#2663
Keith-CY merged 3 commits into
nervosnetwork:developfrom
yanguoyu:fix-deposite-dao

Conversation

@yanguoyu
Copy link
Copy Markdown
Contributor

@yanguoyu yanguoyu commented May 10, 2023

  1. When refreshing in DAO page, the network is not ready, so ignore 404.
  2. Reset deposited DAO capacity when opening dialog to fix deposit can only deposit the amount of 102 Magickbase/neuron-public-issues#146.
  3. Create a common generateDaoDepositTx hook to create a deposit tx whether despositeValue change or suggestFeeRate change.

1. When refreshing in DAO page, the network is not ready, so ignore 404.
2. Reset deposited DAO capacity when opening dialog.
3. Create a common `generateDaoDepositTx` hook to create a deposit tx whether `despositeValue` change or `suggestFeeRate` change
@Keith-CY Keith-CY requested review from FrederLu and silySuper May 11, 2023 03:43
Comment thread packages/neuron-ui/src/components/NervosDAO/index.tsx Outdated
Comment thread packages/neuron-ui/src/components/NervosDAO/index.tsx Outdated
@Keith-CY Keith-CY merged commit 5950982 into nervosnetwork:develop May 15, 2023
@yanguoyu yanguoyu deleted the fix-deposite-dao branch May 15, 2023 22:24
@Keith-CY Keith-CY mentioned this pull request May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deposit can only deposit the amount of 102

3 participants