feat: improve the interaction design of the DatetimePicker component#2674
Conversation
|
Please review the interaction @Danie0918, @Sven-TBD |
|
Note that when no date is selected, the save button is unavailable instead of hidden. In this case, it is recommended to unify the copywriting as "locked to". |
308867a to
97c1264
Compare
Resolved |
e4ddb37 to
dc37192
Compare
|
This is the result after making changes based on the comments in the PR: iShot_2023-05-22_11.22.02.mp4Additionally, for the translation key, I chose to use
@Danie0918 Should I specify a new key, or should we continue using "release-on"? |
Verified |
…en a value is provided
dc37192 to
a9eea2e
Compare
|
Please have a review @FrederLu @silySuper @littleLip520 |
|
@WhiteMinds |
|
@Keith-CY I believe it's quite common for the source branch of a PR to not be on the main repository. Considering that, we should modify the workflow. Here are a few options:
@FrederLu I have just pushed the branch to the main repository. You can now access the packaging result through this link: a9eea2e#commitcomment-114552831 |
I'll open an issue to improve the workflow of packaging for test Will be tracked at Magickbase/neuron-public-issues#154 |
Thanks, the test package has been downloaded through the portal. |






feat: improve the interaction design of the DatetimePicker component
Ref: Magickbase/neuron-public-issues#151
iShot_2023-05-19_10.44.07.mp4