fix: Fix some bugs.#2675
Merged
Keith-CY merged 2 commits intoMay 22, 2023
Merged
Conversation
1. When the light client just started, some dep cells should wait for a moment to get. So if the current light client can not get the dep cells, wait for 10 seconds and try it again. 2. If process. stdout is `pipe`, it should add event listener, otherwise when call process. kill, we need to destroy the stdout 3. If we clean data without cleaning the indexer data, we should not restart the ckb node. 4. When we clean data, restart the sync task to avoid the check node skipping.
yanguoyu
requested review from
FrederLu,
Keith-CY,
WhiteMinds,
alexsupa597,
devchenyan,
littleLip520 and
silySuper
6 tasks
Keith-CY
reviewed
May 21, 2023
Keith-CY
approved these changes
May 21, 2023
devchenyan
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipe, it should add event listener, otherwise when call process. kill, we need to destroy the stdout