Skip to content

refactor: upgrade lumos to 0.21 #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Keith-CY merged 7 commits into from
Dec 14, 2023
Merged

refactor: upgrade lumos to 0.21 #2964

Keith-CY merged 7 commits into from
Dec 14, 2023

Conversation

@homura
Copy link
Contributor

@homura homura commented Nov 29, 2023 •
edited
Loading

This PR upgraded lumos to 0.21 to work with the fetch API

@homura homura marked this pull request as draft November 29, 2023 11:38
@homura homura changed the title chore: upgrade lumos to 0.21 refactor: upgrade lumos to 0.21 Nov 29, 2023
@homura homura marked this pull request as ready for review November 29, 2023 13:52
@homura homura requested review from Keith-CY, yanguoyu and zhangyouxin and removed request for Keith-CY and zhangyouxin November 29, 2023 13:52
@homura
Copy link
Contributor Author

homura commented Nov 30, 2023 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 7041628040. @homura

@homura
Copy link
Contributor Author

homura commented Nov 30, 2023

hi @silySuper, this PR replaces the HTTP client, and the impact of it is the connections between Neuron and CKB(Light client) node. Could you help to check

  • whether the access speed of features is OK, such as sync, list of asset information, or sending transactions, that heavily depends on the CKB RPCs
  • whether the exiting is correct for both neuron and its CKB or Light client when Nueron exits

@Keith-CY Keith-CY requested a review from silySuper November 30, 2023 05:57
Keith-CY
Keith-CY reviewed Nov 30, 2023
View reviewed changes
Keith-CY
Keith-CY reviewed Dec 11, 2023
View reviewed changes
@Keith-CY
Copy link
Collaborator

Keith-CY commented Dec 11, 2023

type Node(https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/src/types/ckbComponents.d.ts#L47-L48) could be updated because httpAgent and httpsAgent are removed

@Keith-CY Keith-CY enabled auto-merge December 14, 2023 08:56
@Keith-CY Keith-CY added this pull request to the merge queue Dec 14, 2023
Merged via the queue into nervosnetwork:develop with commit f598a0f Dec 14, 2023
@homura homura deleted the lumos-0.21 branch December 14, 2023 08:57
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@homura @yanguoyu
refactor: upgrade lumos to 0.21 (nervosnetwork#2964)
b3cb8f2 
* chore: upgrade lumos to 0.21

* refactor: fetch with keepalive to replace the http agent

* refactor: rename variable for more clear

* chore: upgrade lumos to 0.21.1

* refactor: remove unnecessary http agent

* refactor: remove unnecessary global declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@silySuper silySuper Awaiting requested review from silySuper

+1 more reviewer

@yanguoyu yanguoyu yanguoyu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@homura @Keith-CY @yanguoyu