fix: Fix light client sync tx type. #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/package |
yanguoyu
force-pushed
the
fix-light-tx-type
branch
from
0eda81a to
106f520
Compare
Contributor
Author
|
/package |
yanguoyu
requested review from
FrederLu,
Keith-CY,
WhiteMinds,
devchenyan,
homura and
silySuper
Contributor
Author
|
/package |
Collaborator
|
This issue blocked v0.112.0 which includes a fix for nervos dao withdrawal, please prioritize this one @homura @WhiteMinds @devchenyan |
Keith-CY
reviewed
Dec 1, 2023
Keith-CY
reviewed
Dec 1, 2023
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-cache-service.ts
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-cache-service.ts
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/indexer-cache-service.ts
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/light-connector.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/light-connector.ts
Outdated
Show resolved
Hide resolved
Keith-CY
reviewed
Dec 1, 2023
packages/neuron-wallet/src/block-sync-renderer/sync/connector.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/connector.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/connector.ts
Outdated
Show resolved
Hide resolved
packages/neuron-wallet/src/block-sync-renderer/sync/connector.ts
Outdated
Show resolved
Hide resolved
yanguoyu
force-pushed
the
fix-light-tx-type
branch
3 times, most recently
from
d43a959 to
daffc24
Compare
Contributor
Author
|
/package |
homura
reviewed
Dec 2, 2023
packages/neuron-wallet/src/block-sync-renderer/sync/connector.ts
Outdated
Show resolved
Hide resolved
yanguoyu
force-pushed
the
fix-light-tx-type
branch
from
ff4b013 to
45bf8da
Compare
yanguoyu
force-pushed
the
fix-light-tx-type
branch
from
45bf8da to
457a0e1
Compare
Keith-CY
approved these changes
Dec 4, 2023
homura
approved these changes
Dec 4, 2023
|
/package Packaging for test is done in 7083894138. @silySuper |
silySuper
approved these changes
Dec 5, 2023
Co-authored-by: homura <homura.dev@gmail.com>
yanguoyu
force-pushed
the
fix-light-tx-type
branch
from
3ff70f3 to
180fdb7
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
* chore: Update ckb node assume valid target for rc/v0.112.0. * chore: update versions and changelogs * feat: Update Neuron compatibility table * fix: Fix light client sync tx type. (#2965) * fix: Fix light client sync tx type. * feat: update ckb client versions (#2970) * chore: Update ckb node assume valid target (#2968) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update Neuron compatibility table (#2971) Co-authored-by: Keith-CY <Keith-CY@users.noreply.github.com> * chore: Update ckb node assume valid target for rc/v0.112.0. (#2972) * chore: update release date --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Keith-CY <Keith-CY@users.noreply.github.com> Co-authored-by: 严国宇 <841185308@qq.com>
yanguoyu
added a commit
to yanguoyu/neuron
that referenced
this pull request
Mar 14, 2024
* chore: Update ckb node assume valid target for rc/v0.112.0. * chore: update versions and changelogs * feat: Update Neuron compatibility table * fix: Fix light client sync tx type. (nervosnetwork#2965) * fix: Fix light client sync tx type. * feat: update ckb client versions (nervosnetwork#2970) * chore: Update ckb node assume valid target (nervosnetwork#2968) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update Neuron compatibility table (nervosnetwork#2971) Co-authored-by: Keith-CY <Keith-CY@users.noreply.github.com> * chore: Update ckb node assume valid target for rc/v0.112.0. (nervosnetwork#2972) * chore: update release date --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Keith-CY <Keith-CY@users.noreply.github.com> Co-authored-by: 严国宇 <841185308@qq.com>
yanguoyu
added a commit
to yanguoyu/neuron
that referenced
this pull request
Mar 14, 2024
* fix: Fix light client sync tx type.
yanguoyu
added a commit
to yanguoyu/neuron
that referenced
this pull request
Mar 14, 2024
* fix: Fix light client sync tx type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to Magickbase/neuron-public-issues#329