Skip to content

Conversation

@devchenyan
Copy link
Contributor

@devchenyan
Copy link
Contributor Author

devchenyan commented Dec 24, 2023

/package
Packaging for test is done in 7313710524. @devchenyan

@Keith-CY
Copy link
Collaborator

Screen.Recording.2023-12-26.at.18.58.19.mov

The dialog shows repeatedly when it's dismissed by esc button

BTW, the confirm button should be white text color when it's in dark mode

@devchenyan
Copy link
Contributor Author

devchenyan commented Jan 1, 2024

Screen.Recording.2023-12-26.at.18.58.19.mov
The dialog shows repeatedly when it's dismissed by esc button

BTW, the confirm button should be white text color when it's in dark mode

In the design criteria, the cancel button should be gray and the confirm button should be black text color when it's in dark mode.
image

@devchenyan
Copy link
Contributor Author

devchenyan commented Jan 2, 2024

/package
Packaging for test is done in 7381461129. @devchenyan

@yanguoyu yanguoyu added this pull request to the merge queue Jan 5, 2024
Merged via the queue into develop with commit 1eea695 Jan 5, 2024
@yanguoyu yanguoyu deleted the fix-336 branch January 5, 2024 01:30
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
* fix: issue 336

* fix: AlertDialog

---------

Co-authored-by: Chen Yu <keithwhisper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants