Skip to content

fix: Remove walletId for get-multisig-config API #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Keith-CY merged 1 commit into from
Jan 17, 2024
Merged

fix: Remove walletId for get-multisig-config API #3010

Keith-CY merged 1 commit into from
Jan 17, 2024

Conversation

@yanguoyu
Copy link
Contributor

@yanguoyu yanguoyu commented Jan 4, 2024

Refer to Magickbase/neuron-public-issues#348

  1. Remove walletId for get-multisig-config API
  2. Disabled Approve button when the current wallet can not sign for the multisig config.
multisig.mov

@yanguoyu yanguoyu mentioned this pull request Jan 4, 2024
Closed
Keith-CY
Keith-CY reviewed Jan 7, 2024
View reviewed changes
@Keith-CY Keith-CY mentioned this pull request Jan 8, 2024
Closed
@yanguoyu
Copy link
Contributor Author

yanguoyu commented Jan 8, 2024 •
edited by github-actions bot
Loading

/package
Packageing failed in 7442809819. @yanguoyu

@silySuper
Copy link

silySuper commented Jan 12, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 7499517505. @silySuper

@silySuper
Copy link

silySuper commented Jan 16, 2024 •
edited
Loading

After switching different wallets for several times,sync process is stoped,even I have exited and open app again.

2024-01-16.10.21.14.mov

@yanguoyu
Copy link
Contributor Author

yanguoyu commented Jan 16, 2024 •
edited
Loading

After switching different wallets for several times,sync process is stoped,even I have exited and open app again.

2024-01-16.10.21.14.mov
Uploading neuron_debug_1705371474620.zip…

Does the multisig sync to 99.95% block height? If not, it's normal because the light client should wait for the least sync block number.
And We will optimate the multisig sync, then the multisig address also supports setting the start block number.

@silySuper
Copy link

silySuper commented Jan 16, 2024

This is multisig sync,already to 99.95% block height
截屏2024-01-16 10 28 21

@yanguoyu
Copy link
Contributor Author

yanguoyu commented Jan 16, 2024

This is multisig sync,already to 99.95% block height 截屏2024-01-16 10 28 21

Thanks, I will find out what happened, besides, the debug information does not upload success in the up comment.

@silySuper
Copy link

silySuper commented Jan 16, 2024

截屏2024-01-16 10 32 34 debug log shows this ,does this affect?

neuron_debug_1705372285343.zip

@yanguoyu
fix: Remove walletId for get-multisig-config API
a28570b 
1. Remove walletId for `get-multisig-config` API
2. Disabled `Approve` button when the current wallet can not sign for the multisig config.
@yanguoyu
Copy link
Contributor Author

yanguoyu commented Jan 17, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 7549292195. @yanguoyu

@Keith-CY Keith-CY merged commit 7fe4b4d into nervosnetwork:develop Jan 17, 2024
@yanguoyu yanguoyu deleted the fix-multisig branch January 17, 2024 06:52
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@yanguoyu
fix: Remove walletId for get-multisig-config API (nervosnetwork#3010)
7a75589
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@homura homura Awaiting requested review from homura

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds

@FrederLu FrederLu Awaiting requested review from FrederLu

+2 more reviewers

@devchenyan devchenyan devchenyan approved these changes

@silySuper silySuper silySuper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanguoyu @silySuper @Keith-CY @devchenyan