Skip to content

Conversation

@yanguoyu
Copy link
Contributor

  1. Add left time for sync progress
image image
  1. Move the global dialog to the button when clicking Refresh
image

1. Add left time for sync
2. Move global loading to button when clear cache.
@yanguoyu yanguoyu marked this pull request as ready for review January 18, 2024 08:06
@yanguoyu
Copy link
Contributor Author

@devchenyan @WhiteMinds @homura Please have a review.

@silySuper
Copy link

silySuper commented Jan 23, 2024

/package
Packaging for test is done in 7623162899. @silySuper

@silySuper
Copy link

silySuper commented Feb 21, 2024

/package
Packaging for test is done in 7982842697. @silySuper

@silySuper
Copy link

1.In light client mode,left time shown after sync 0.2%,in expect after sync is begin it should show

2024-02-21.16.14.35.mov

2.In light client mode,left time is increasing when sync process is increasing actually,in expect left time and sync process data should inverse ratio.

2024-02-21.15.34.36.mov

3.By the way ,another UI problem:
when window is minimum,language after English(United States) can not show and chose.Maybe add scroll bar is better.

2024-02-21.16.24.07.mov

@yanguoyu
Copy link
Contributor Author

yanguoyu commented Feb 21, 2024

3.By the way ,another UI problem:
when window is minimum,language after English(United States) can not show and chose.Maybe add scroll bar is better.

I believe it will be better to open a new issue to track this problem.

@yanguoyu
Copy link
Contributor Author

Because the sync speed depends on the latest tip block number, network speed, and synced block number so it will keep correcting during synchronization.

@silySuper
Copy link

Ok,Maybe No.1 and No.2 will cause users confused .@Danie0918 should know this actual effect.
No.3 bug new link: Magickbase/neuron-public-issues#357

@Danie0918
Copy link

Ok,Maybe No.1 and No.2 will cause users confused .@Danie0918 should know this actual effect. No.3 bug new link: Magickbase/neuron-public-issues#357

This is the estimated time, and it's understandable that the remaining time changes, and I'll consider adding instructions subsequently.

@yanguoyu yanguoyu added this pull request to the merge queue Feb 22, 2024
Merged via the queue into nervosnetwork:develop with commit 1d31fe1 Feb 22, 2024
@yanguoyu yanguoyu deleted the feat-add-left-time branch February 22, 2024 02:28
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
feat: Add left time.

1. Add left time for sync
2. Move global loading to button when clear cache.

Co-authored-by: Chen Yu <keithwhisper@gmail.com>
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants