Skip to content

Conversation

@yanguoyu
Copy link
Contributor

@yanguoyu yanguoyu commented Feb 29, 2024

Add a whitelist for packaging with comments.
Here is a skip example when the commented username is not in the whitelist or not the repo owner yanguoyu#100

@yanguoyu yanguoyu force-pushed the feat-add-action-whitelist branch from 2b98254 to f01697a Compare February 29, 2024 09:27
@yanguoyu yanguoyu force-pushed the feat-add-action-whitelist branch from f01697a to 498a349 Compare March 1, 2024 13:11
@Keith-CY Keith-CY self-requested a review March 3, 2024 15:32
@Keith-CY
Copy link
Collaborator

Keith-CY commented Mar 3, 2024

The action has been disabled, we should have a discussion before making a decision

@yanguoyu yanguoyu force-pushed the feat-add-action-whitelist branch 2 times, most recently from cf38e10 to c08b8c4 Compare March 4, 2024 04:19
@yanguoyu yanguoyu force-pushed the feat-add-action-whitelist branch from ab3f329 to 217e381 Compare March 8, 2024 05:12
@yanguoyu
Copy link
Contributor Author

yanguoyu commented Mar 8, 2024

I have modified the package_for_test.yml as Magickbase/neuron-public-issues#364 (comment) and Magickbase/neuron-public-issues#364 (comment) described.
If there are no further issues, I will merge this PR. @Keith-CY @devchenyan @homura

@Keith-CY
Copy link
Collaborator

Keith-CY commented Mar 8, 2024

I have modified the package_for_test.yml as Magickbase/neuron-public-issues#364 (comment) and Magickbase/neuron-public-issues#364 (comment) described. If there are no further issues, I will merge this PR. @Keith-CY @devchenyan @homura

LGTM

@yanguoyu yanguoyu force-pushed the feat-add-action-whitelist branch 2 times, most recently from 21bfa1f to 72b653b Compare March 9, 2024 12:20
@yanguoyu yanguoyu marked this pull request as draft March 11, 2024 00:26
@yanguoyu yanguoyu force-pushed the feat-add-action-whitelist branch from 23a75f0 to ba80edd Compare March 12, 2024 05:40
@yanguoyu yanguoyu marked this pull request as ready for review March 12, 2024 06:35
@yanguoyu yanguoyu added this pull request to the merge queue Mar 12, 2024
Merged via the queue into nervosnetwork:develop with commit 9d19dec Mar 12, 2024
@yanguoyu yanguoyu deleted the feat-add-action-whitelist branch March 12, 2024 06:38
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
* chore: Only MEMBER and OWNER can package with comment.

* chore: Add permissions for package test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants