Skip to content

Fix cell manage with hard wallet #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yanguoyu merged 2 commits into from
Mar 14, 2024
Merged

Fix cell manage with hard wallet #3069

yanguoyu merged 2 commits into from
Mar 14, 2024

Conversation

@yanguoyu
Copy link
Contributor

@yanguoyu yanguoyu commented Mar 13, 2024

  1. Support lock or unlock when using a hard wallet
verify-ledger.mov
  1. Show the tx hash in the cell info dialog
image

@yanguoyu yanguoyu force-pushed the fix-cell-manage-with-hard-wallet branch from 45aa142 to 61524a3 Compare March 13, 2024 03:51
@Danie0918
Copy link

Danie0918 commented Mar 13, 2024

@devchenyan @homura @Keith-CY Please have a review.

@homura
Copy link
Contributor

homura commented Mar 13, 2024

IMO, it is best to minimize the use of passwords or hardware to reduce the risk of exposing private keys

I am not sure whether it is essential to logically unlock client-side cells through a hardware device since these cells are not physically locked but rather prevented from being spent by the wallet

@yanguoyu
Copy link
Contributor Author

yanguoyu commented Mar 13, 2024

IMO, it is best to minimize the use of passwords or hardware to reduce the risk of exposing private keys

I am not sure whether it is essential to logically unlock client-side cells through a hardware device since these cells are not physically locked but rather prevented from being spent by the wallet

Magickbase/neuron-public-issues#218 (comment) This the suggestion from the PM

Keith-CY
Keith-CY reviewed Mar 13, 2024
View reviewed changes
@yanguoyu yanguoyu force-pushed the fix-cell-manage-with-hard-wallet branch from 61524a3 to 32fac32 Compare March 13, 2024 13:10
@yanguoyu yanguoyu requested a review from Keith-CY March 13, 2024 13:11
@silySuper
Copy link

silySuper commented Mar 14, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 8274137465. @silySuper

@yanguoyu yanguoyu added this pull request to the merge queue Mar 14, 2024
Merged via the queue into nervosnetwork:develop with commit 4055ab6 Mar 14, 2024
@yanguoyu yanguoyu deleted the fix-cell-manage-with-hard-wallet branch March 14, 2024 04:44
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@yanguoyu
Fix cell manage with hard wallet (nervosnetwork#3069)
1d22115 
* fix: Adapt hard wallet for lock and unlock live cell.

* fix: Add tx hash for cell info dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@homura homura Awaiting requested review from homura

+2 more reviewers

@devchenyan devchenyan devchenyan approved these changes

@silySuper silySuper silySuper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yanguoyu @Danie0918 @homura @silySuper @Keith-CY @devchenyan