Skip to content

feat: compatible ckb-cli tx multisig file #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Keith-CY merged 12 commits into from
Jun 7, 2024
Merged

feat: compatible ckb-cli tx multisig file #3169

Keith-CY merged 12 commits into from
Jun 7, 2024

Conversation

@devchenyan
Copy link
Contributor

@devchenyan devchenyan commented May 26, 2024

issue: Magickbase/neuron-public-issues#377

ckb-cli tx multisig file:
transaction_cli.json

Screen-2024-05-27-021744.mp4

@devchenyan devchenyan mentioned this pull request May 26, 2024
Closed
yanguoyu
yanguoyu reviewed May 27, 2024
View reviewed changes
@Danie0918
Copy link

Danie0918 commented May 27, 2024

@homura Please have a review.

@devchenyan devchenyan requested a review from yanguoyu May 27, 2024 03:55
@devchenyan
Copy link
Contributor Author

devchenyan commented May 27, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9251063539. @devchenyan

homura
homura reviewed May 28, 2024
View reviewed changes
@Danie0918 Danie0918 requested a review from twhy May 30, 2024 01:20
@Danie0918
Copy link

Danie0918 commented May 30, 2024

@homura Please have a review.

Keith-CY
Keith-CY reviewed May 30, 2024
View reviewed changes
@Danie0918
Copy link

Danie0918 commented Jun 5, 2024

@Keith-CY @homura Please have a review.

Keith-CY
Keith-CY reviewed Jun 5, 2024
View reviewed changes
@devchenyan devchenyan requested review from homura and silySuper June 5, 2024 03:00
@silySuper
Copy link

silySuper commented Jun 5, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9377511492. @silySuper

homura
homura approved these changes Jun 5, 2024
View reviewed changes
@silySuper
Copy link

silySuper commented Jun 6, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9393978809. @silySuper

@silySuper
Copy link

silySuper commented Jun 7, 2024

1.Click confirm button firstly,then click send will cause network reconnect.

2024-06-07.09.49.59.mov

2.After click confirm button ,pop up window does not show confirm button ,but only shows cancel button.

2024-06-07.09.48.59.mov

@devchenyan
Copy link
Contributor Author

devchenyan commented Jun 7, 2024

1.Click confirm button firstly,then click send will cause network reconnect.

2024-06-07.09.49.59.mov
2.After click confirm button ,pop up window does not show confirm button ,but only shows cancel button.

2024-06-07.09.48.59.mov

2、Multi-signing requires other accounts to have completed signing before the confirm button is available.

@devchenyan
Copy link
Contributor Author

devchenyan commented Jun 7, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9411294269. @devchenyan

@devchenyan
Copy link
Contributor Author

devchenyan commented Jun 7, 2024

@silySuper 1、 fixed

@Keith-CY Keith-CY mentioned this pull request Jun 7, 2024
Closed
@Keith-CY Keith-CY merged commit 77d99fb into develop Jun 7, 2024
@Keith-CY Keith-CY deleted the feat-377 branch June 7, 2024 08:26
@Keith-CY Keith-CY mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@twhy twhy Awaiting requested review from twhy

+3 more reviewers

@homura homura homura approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@silySuper silySuper silySuper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@devchenyan @Danie0918 @silySuper @Keith-CY @homura @yanguoyu