Skip to content

feat: Support UDT destruction #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devchenyan merged 10 commits into from
Mar 6, 2025
Merged

feat: Support UDT destruction #3323

devchenyan merged 10 commits into from
Mar 6, 2025

Conversation

@devchenyan
Copy link
Contributor

@devchenyan devchenyan commented Feb 27, 2025 •
edited
Loading

issue:

1.mov
  • Cell Management
2.mov
  • HardWallet
Screen-2025-02-27-181813.mp4

@Danie0918 Danie0918 requested review from Keith-CY and yanguoyu and removed request for Keith-CY and yanguoyu February 27, 2025 07:12
@devchenyan devchenyan marked this pull request as ready for review February 27, 2025 10:00
@devchenyan devchenyan mentioned this pull request Feb 27, 2025
Open
Keith-CY
Keith-CY reviewed Feb 28, 2025
View reviewed changes
@yanguoyu
Copy link
Contributor

yanguoyu commented Feb 28, 2025

Could you upload a screenshot of recycling the cell in the cell-management page? I get that we can recycle selected cells but here https://github.com/nervosnetwork/neuron/pull/3323/files#diff-d920ea38b5341527c5912ada1449a2808d5319f9e731cf26b61684f50552608bR396-R398 only transfer one token.

@devchenyan
Copy link
Contributor Author

devchenyan commented Feb 28, 2025

Could you upload a screenshot of recycling the cell in the cell-management page? I get that we can recycle selected cells but here https://github.com/nervosnetwork/neuron/pull/3323/files#diff-d920ea38b5341527c5912ada1449a2808d5319f9e731cf26b61684f50552608bR396-R398 only transfer one token.

The wrong video was uploaded earlier, and the video has now been updated.

image

@devchenyan devchenyan requested a review from Keith-CY February 28, 2025 08:32
yanguoyu
yanguoyu reviewed Mar 3, 2025
View reviewed changes
@silySuper
Copy link

silySuper commented Mar 3, 2025 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 13625134889. @silySuper

@silySuper
Copy link

silySuper commented Mar 4, 2025 •
edited
Loading

1.When destroy 0.0 udt ,it shows +,inexpect it should shows -
截屏2025-03-04 11 32 05

@silySuper
Copy link

silySuper commented Mar 5, 2025

link issue：Magickbase/neuron-public-issues#445

@devchenyan
Copy link
Contributor Author

devchenyan commented Mar 6, 2025 •
edited
Loading

1.When destroy 0.0 udt ,it shows +,inexpect it should shows - 截屏2025-03-04 11 32 05

fixed. @silySuper
image

@silySuper
Copy link

silySuper commented Mar 6, 2025 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 13689829089. @silySuper

@devchenyan devchenyan added this pull request to the merge queue Mar 6, 2025
Merged via the queue into develop with commit ecd4095 Mar 6, 2025
23 checks passed
@devchenyan devchenyan deleted the feat-420 branch March 6, 2025 03:43
@Keith-CY Keith-CY mentioned this pull request May 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@homura homura Awaiting requested review from homura

+2 more reviewers

@yanguoyu yanguoyu yanguoyu approved these changes

@silySuper silySuper silySuper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devchenyan @yanguoyu @silySuper @Keith-CY