Skip to content

Conversation

@devchenyan
Copy link
Contributor

@devchenyan devchenyan commented Apr 23, 2025

@devchenyan devchenyan marked this pull request as draft April 23, 2025 16:18
@Danie0918 Danie0918 requested review from Keith-CY, homura and yanguoyu and removed request for Keith-CY, homura and yanguoyu April 24, 2025 01:02
@Keith-CY
Copy link
Collaborator

Please set it to ready for review if no more updates are required.

@devchenyan devchenyan marked this pull request as ready for review April 24, 2025 03:06
@Danie0918
Copy link

@Keith-CY @yanguoyu Please review.

@silySuper
Copy link

silySuper commented May 20, 2025

4.After regenerate ,send 100000 ckb to new multisig address:ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqkqxc7hdxa4a9lj45d664fzy5h227xrmjq9mjla9 ,but actually old address:ckt1qpw9q60tppt7l3j7r09qcp7lxnp3vcanvgha8pmvsa3jplykxn32sqwqxc7hdxa4a9lj45d664fzy5h227xrmjqfh9cux receive this ckb.
截屏2025-05-16 17 47 23 截屏2025-05-16 17 59 39 截屏2025-05-16 17 47 36

Through Neuron, transferring CKB to the new multi-signature address works normally,eg:testnet.explorer.nervos.org/transaction/0x228d857699132eed1031fb7f2d46c50b47c4ebdba00643ddfb232b37c982b696. @Danie0918 This issue likely requires the CKB explorer's faucet to resolve.

Need to update ckb-sdk-ruby to support new multisig, expect it to take 1-2 days.

Fixing faucet can be an independent issue that not blocks this one.

Yes,No.5 and No.7 need check firstly which block main flow.

@Danie0918
Copy link

4.After regenerate ,send 100000 ckb to new multisig address:ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqkqxc7hdxa4a9lj45d664fzy5h227xrmjq9mjla9 ,but actually old address:ckt1qpw9q60tppt7l3j7r09qcp7lxnp3vcanvgha8pmvsa3jplykxn32sqwqxc7hdxa4a9lj45d664fzy5h227xrmjqfh9cux receive this ckb.
截屏2025-05-16 17 47 23 截屏2025-05-16 17 59 39 截屏2025-05-16 17 47 36

Through Neuron, transferring CKB to the new multi-signature address works normally,eg:testnet.explorer.nervos.org/transaction/0x228d857699132eed1031fb7f2d46c50b47c4ebdba00643ddfb232b37c982b696. @Danie0918 This issue likely requires the CKB explorer's faucet to resolve.

Need to update ckb-sdk-ruby to support new multisig, expect it to take 1-2 days.

Fixing faucet can be an independent issue that not blocks this one.

Yes, this is just a notification. Testing and fixes are still in progress.

@silySuper
Copy link

7.When unlock in multisig dao, click confirm ,shows no matched address.
image
sync progress: image image
log: main.log

Please check the synchronization and whether the synchronization is complete for the external light nodes. I can reproduce this error when the actual blockNumber of the light node is too large or when it fails to synchronize to the addresses that the multi-signature address depends on.

As shown in the image, the number of addresses on the left (full node) is much higher than the address data on the right (light node).

WX20250520-105612

I start node and multisig sync from first transaction .

@silySuper
Copy link

8.When send ckb from ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjq5au6zycas6yf0t5q39v05vmjfmt46heug2fq7x5 which has 100000ckb
to ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqslatlnhk995s56dwznl7uh0numrshsn6qum0eg8 ,transaction status is untracked in ckb browser. And from address balance become 0ckb for a long time.
截屏2025-05-20 15 14 03

https://testnet.explorer.nervos.org/transaction/0x3aeb054f290b54dd079336ea9b1bb9ccabb9cfa10a9a3f30ac60dd1f71dd70ae

main.log

@silySuper
Copy link

silySuper commented May 21, 2025

9.use multisig address:ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqskdknevh0elzppujsn4vdx63hhxyr3jyq5vqnfs send to two addresses one is :ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq2s5a3mw0mragce4sp0dj7fmmcq6e44z9qw25t37 and the other one is ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq2s5a3mw0mragce4sp0dj7fmmcq6e44z9qw25t37
transaction status is pending ,and ckb browser can not found this transation

截屏2025-05-21 15 19 20

tx hash:0x8d937b793b67d05c3d1cc3eddbd04fa07ac5bd3c928320f7b633fc46f44d9630
截屏2025-05-21 15 17 08

main.log

截屏2025-05-21 15 36 36

@silySuper
Copy link

10.multisig address :ckt1qpw9q60tppt7l3j7r09qcp7lxnp3vcanvgha8pmvsa3jplykxn32sqgqwgqfnudmunpuudhh9wuk9ahug8pkmlqhxn9gt
deposit 337.99998876CKB (before is 400CKB),After that test package shows 62CKB balance,online package shows 0CKB
online package:
截屏2025-05-21 15 59 00

test package:
截屏2025-05-21 15 59 31

@devchenyan
Copy link
Contributor Author

10.multisig address :ckt1qpw9q60tppt7l3j7r09qcp7lxnp3vcanvgha8pmvsa3jplykxn32sqgqwgqfnudmunpuudhh9wuk9ahug8pkmlqhxn9gt deposit 337.99998876CKB (before is 400CKB),After that test package shows 62CKB balance,online package shows 0CKB online package: 截屏2025-05-21 15 59 00

test package: 截屏2025-05-21 15 59 31

ckt1qpw9q60tppt7l3j7r09qcp7lxnp3vcanvgha8pmvsa3jplykxn32sqgqwgqfnudmunpuudhh9wuk9ahug8pkmlqhxn9gt has no transaction record.
image

@silySuper
Copy link

4.After regenerate ,send 100000 ckb to new multisig address:ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqkqxc7hdxa4a9lj45d664fzy5h227xrmjq9mjla9 ,but actually old address:ckt1qpw9q60tppt7l3j7r09qcp7lxnp3vcanvgha8pmvsa3jplykxn32sqwqxc7hdxa4a9lj45d664fzy5h227xrmjqfh9cux receive this ckb.
截屏2025-05-16 17 47 23 截屏2025-05-16 17 59 39 截屏2025-05-16 17 47 36

Through Neuron, transferring CKB to the new multi-signature address works normally,eg:https://testnet.explorer.nervos.org/transaction/0x228d857699132eed1031fb7f2d46c50b47c4ebdba00643ddfb232b37c982b696. @Danie0918 This issue likely requires the CKB explorer's faucet to resolve.

meanwhile,in overview page send ckb to new multisig address: A:ckt1qqmvjudc6s0mm992hjnhm367sfnjntycg3a5d7g7qpukz4wamvxjjqjgptucyht6avrnn7n5pv5txx3tnleaw5saknhs8 , B:ckt1qpw9q60tppt7l3j7r09qcp7lxnp3vcanvgha8pmvsa3jplykxn32sq2gptucyht6avrnn7n5pv5txx3tnleaw5s36ys3y receive this ckb actually. A is regenerated by B

截屏2025-05-22 12 03 19 截屏2025-05-22 12 03 51

@devchenyan
Copy link
Contributor Author

devchenyan commented May 22, 2025

  1. fixed
  2. Not issue. If the multi-signature only requires one signature, it will display Confirm and allow directly signing to send the transaction. This is expected behavior.
  3. fixed
  4. fixed
  5. the wallet did not complete syncing properly
  6. fixed
  7. the wallet did not complete syncing properly
  8. fixed
  9. fixed
  10. Not issue. The issue is caused by mixing old and new version neurons, where the old version neuron cannot recognize the new multi-signature script.

@silySuper
Copy link

silySuper commented May 23, 2025

/package
Packaging for test is done in 15204397270. @silySuper

@silySuper
Copy link

No.4 is as before
截屏2025-05-23 16 32 03

截屏2025-05-23 16 32 50

@devchenyan
Copy link
Contributor Author

No.4 is as before 截屏2025-05-23 16 32 03

截屏2025-05-23 16 32 50

fixed

@silySuper
Copy link

silySuper commented May 26, 2025

/package
Packaging for test is done in 15244472905. @silySuper

@silySuper
Copy link

11.When click concise data in approve window,sometimes it flashes

2025-05-26.15.33.12.mov

@devchenyan
Copy link
Contributor Author

11.When click concise data in approve window,sometimes it flashes

2025-05-26.15.33.12.mov

fixed @silySuper

@silySuper
Copy link

silySuper commented May 27, 2025

/package
Packaging for test is done in 15265021326. @silySuper

@devchenyan devchenyan enabled auto-merge May 27, 2025 02:30
@devchenyan devchenyan disabled auto-merge May 27, 2025 02:31
@devchenyan devchenyan added this pull request to the merge queue May 27, 2025
Merged via the queue into nervosnetwork:develop with commit 948b7a7 May 27, 2025
10 checks passed
@devchenyan devchenyan deleted the fix-dao branch May 27, 2025 02:36
@Keith-CY Keith-CY mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants