Open
Conversation
Reimplemented the `create_app` function to create processes for individual source/filter/output modules instead of running the modules directly in a sequential loop in the main method. Instead of this the main app loop simply follows a sequence of multiprocessing.connection.Connection calls to send and receive data from the parallel processes. In-between the process communication we do additional "merge" logic similar to what we've done previously as this likely helps with improving some efficiency. This should improve the overall performance of the tool at the expense of burning more cpu cores for the parallel processes. Signed-off-by: Ondrej Lichtner <ilichtner@fit.vutbr.cz>
olichtne
force-pushed
the
parallelization
branch
from
2c75641 to
35237aa
Compare
Author
|
tested and pushed fixes, discussed with Ondra that the next step is to deploy into production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplemented the
create_appfunction to create processes for individual source/filter/output modules instead of running the modules directly in a sequential loop in the main method.Instead of this the main app loop simply follows a sequence of multiprocessing.connection.Connection calls to send and receive data from the parallel processes.
In-between the process communication we do additional "merge" logic similar to what we've done previously as this likely helps with improving some efficiency.
This should improve the overall performance of the tool at the expense of burning more cpu cores for the parallel processes.