chore: replace Corrade 2020.06 with cci.20250327 for macOS build#767
Closed
leoparente wants to merge 10 commits intodevelopfrom
Closed
chore: replace Corrade 2020.06 with cci.20250327 for macOS build#767leoparente wants to merge 10 commits intodevelopfrom
leoparente wants to merge 10 commits intodevelopfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ugin Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…able API Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…20250327 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…build
- pluginSearchPaths() must return non-empty Array<String> (at least one
entry) when dynamic plugin support is enabled; use Array<String>{1}
to match the old std::vector<std::string>{""} behavior
- Add CORRADE_AUTOMATIC_INITIALIZER include in static_plugins.h headers
(macro moved to Corrade/Utility/Macros.h in new version)
- Fix CoreRegistry.cpp: use try_emplace instead of insert for
std::unique_ptr values; include PointerStl.h for Corrade Pointer
to std::unique_ptr conversion
- Override CMAKE_OSX_SYSROOT after Conan toolchain re-include to fix
'-isysroot macosx' invalid path issue on non-Xcode generators
All 18 unit tests pass.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
corradefrom2020.06tocci.20250327andopentelemetry-cppfrom1.17.0to1.24.0inconanfile.pycci.20250327)CorradeCompat.hto bridgeCorrade::Containers::StringViewwithfmtandstd::stringBreaking API changes addressed (Corrade cci.20250327 vs 2020.06)
AbstractPlugin::plugin()const std::string&Containers::StringViewPluginMetadata::provides()const std::vector<std::string>&Containers::StringIterableAbstractManager::pluginList()std::vector<std::string>Containers::Array<StringView>pluginSearchPaths()std::vector<std::string>{""}Array<String>{1}pluginInterface()std::stringStringView(must haveGlobalflag)CORRADE_AUTOMATIC_INITIALIZERAbstractManager.hUtility/Macros.hconst std::string&const Containers::StringView&Test plan
cmakeconfigure frombuild/withconan_providerto verify no sysroot errorsmake -j4to verify full buildsrc/directory: all 18 test cases pass🤖 Generated with Claude Code