chore: update opentelemetry-cpp, protobuf, GitHub Actions and fix flaky netflow test#768
Merged
leoparente merged 6 commits intodevelopfrom Apr 11, 2026
Merged
Conversation
- opentelemetry-cpp: 1.17.0 → 1.24.0 - protobuf: 5.27.0 → 6.33.5 (major version bump) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e on Windows conan_provider.cmake fires during project() via CMAKE_PROJECT_TOP_LEVEL_INCLUDES, before the previous CMAKE_CXX_STANDARD=17 assignment at line 53. MSVC defaults to C++14, causing protobuf/6.33.5 (which requires C++17) to fail validation on Windows. Moving the standard declaration above project() ensures conan_provider.cmake always detects cppstd=17 regardless of platform. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
conan_provider.cmake passes --profile:build=default to conan install. The auto-detected default on MSVC always sets compiler.cppstd=14, which fails validation for protobuf/6.33.5 (requires C++17) when used as a build/tool requirement. Pre-creating the default profile with cppstd=17 before CMake runs ensures both the host and build profiles agree on the C++ standard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
actions/*:
checkout v4 → v6, cache v4 → v5, upload-artifact v4 → v7,
download-artifact v4 → v8, setup-python v4 → v6
docker/*:
metadata-action v5.6.1 → v6.0.0, login-action v3.3.0 → v4.1.0,
setup-qemu-action v3.2.0 → v4.0.0, setup-buildx-action v3.8.0 → v4.0.0,
build-push-action v6.10.0 → v7.1.0
third-party:
github-script v8.0.0 → v9.0.0, codecov-action v3 → v6.0.0,
codeql-action v3 → v3.35.1 (SHA-pinned), codeql upload-sarif v4.32.6 → v4.35.1,
filter-sarif v1 → v1.1
No change: turtlebrowser/get-conan (v1.2 already latest),
aquasecurity/trivy-action (v0.35.0 already latest),
actions/create-release (archived upstream)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The "Parse netflow v5 stream" test was missing the IpPort::set_csv_iana_ports() call, making it depend on global static state populated by sflow tests that happen to run first. When run in isolation (e.g. --randomize-run-order or filtered by [netflow]), the port map is empty so port 23 resolves to "23" instead of "telnet". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
leoparente
changed the title
mfiedorowicz
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.17.0→1.24.05.27.0→6.33.5(major version bump)CMAKE_CXX_STANDARD 17beforeproject()soconan_provider.cmake(which fires duringproject()viaCMAKE_PROJECT_TOP_LEVEL_INCLUDES) sees the correct standard and does not fall back to MSVC's default C++14build-develop.yml,build-release.yml): add a Setup Conan Profile step that pre-creates the default Conan profile withcppstd=17before CMake runs — fixes--profile:build=defaultpicking up C++14 fortool_requires(protobuf build-time use)Parse netflow v5 streamtest — was silently relying on global state populated by sflow tests; now callsIpPort::set_csv_iana_ports()directly so it is self-contained regardless of run orderTest plan
[netflow]tagged tests pass when run in isolation (no sflow tests before them)--randomize-run-orderdoes not flip the netflow v5 port name assertion🤖 Generated with Claude Code