Ngstack 1017 iri template generation feature #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakovKnezovicc
force-pushed
the
NGSTACK-1017-iri-template-generation
branch
from
7fa0502 to
892ad6a
Compare
emodric
reviewed
Jan 15, 2026
|
|
||
| try { | ||
| $content = json_encode($iriTemplates, JSON_THROW_ON_ERROR | JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES); | ||
| } catch (\JsonException) { |
Member
There was a problem hiding this comment.
Root classes like these should also be imported with use JsonException.
emodric
reviewed
Jan 15, 2026
| IriTemplatesService::class, | ||
| new Definition(IriTemplatesService::class), | ||
| ) | ||
| ->setAutowired(true); |
Member
There was a problem hiding this comment.
In general, autowiring should not be used in vendor libraries because autowiring should always be opt-in for project developers.
emodric
reviewed
Jan 15, 2026
src/Service/IriTemplatesService.php
Outdated
| ) {} | ||
|
|
||
| /** | ||
| * @throws ResourceClassNotFoundException |
Member
There was a problem hiding this comment.
The method does not actually throw anything.
emodric
reviewed
Jan 15, 2026
src/Service/IriTemplatesService.php
Outdated
|
|
||
| use function preg_replace; | ||
|
|
||
| final readonly class IriTemplatesService |
emodric
reviewed
Jan 15, 2026
src/Service/IriTemplatesService.php
Outdated
| $iriTemplates = []; | ||
|
|
||
| foreach ($resourceClasses as $class) { | ||
| /** @var ApiResource $resourceMetadata */ |
emodric
reviewed
Jan 15, 2026
| use const JSON_UNESCAPED_SLASHES; | ||
|
|
||
| #[AsCommand( | ||
| name: 'api-platform-extras:generate-iri-templates', |
Member
There was a problem hiding this comment.
Prefix command names with netgen:
emodric
reviewed
Jan 15, 2026
| use const JSON_THROW_ON_ERROR; | ||
| use const JSON_UNESCAPED_SLASHES; | ||
|
|
||
| #[AsCommand( |
Member
There was a problem hiding this comment.
This will almost certainly clash with service definition in compiler pass.
emodric
reviewed
Jan 15, 2026
|
|
||
| final class IriTemplateGeneratorCompilerPass implements CompilerPassInterface | ||
| { | ||
| private const FEATURE_ENABLED_PARAMETER = 'netgen_api_platform_extras.features.iri_template_generator.enabled'; |
Member
There was a problem hiding this comment.
private const string can be used.
JakovKnezovicc
force-pushed
the
NGSTACK-1017-iri-template-generation
branch
from
892ad6a to
5845b9e
Compare
…ature compiler pass
JakovKnezovicc
force-pushed
the
NGSTACK-1017-iri-template-generation
branch
from
5845b9e to
c4811ee
Compare
Contributor
Author
|
prethodni komentari rijeseni u jednom commitu a36809a |
emodric
reviewed
Jan 16, 2026
| private ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, | ||
| private ResourceNameCollectionFactoryInterface $resourceExtractor, | ||
| private RouterInterface $router, | ||
| private readonly ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory, |
Member
There was a problem hiding this comment.
When I meant we don't need readonly, I meant at all :D It's just unnecessary noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds command and service for generating iri templates in json format using dumper.
Included to container build if enabled as a feature in config passed via container parameter.