Skip to content

chore: Only do gorelease config check on CI#16

Merged
langecode merged 1 commit intomainfrom
feature/no-goreleaser-in-ci
Apr 30, 2025
Merged

chore: Only do gorelease config check on CI#16
langecode merged 1 commit intomainfrom
feature/no-goreleaser-in-ci

Conversation

@langecode
Copy link
Member

  • No dry-run of goreleaser in CI pipeline
  • Inline the run of govulncheck the action does not seem very stable

Fixes #15

@langecode langecode requested a review from a team as a code owner April 29, 2025 08:40
Copy link
Contributor

@KimNorgaard KimNorgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex5517 wanted those goreleaser checks in CI. They are optional.

@langecode
Copy link
Member Author

@alex5517 wanted those goreleaser checks in CI. They are optional.

Ahh, yes, I notice the release test is indeed also optional - my bad. It could just be disabled for Beagle then - but do we ever want to do a "dry-run" of goreleaser during the CI flow 🤔

@ChBLA
Copy link
Contributor

ChBLA commented Apr 29, 2025

@alex5517 wanted those goreleaser checks in CI. They are optional.

Ahh, yes, I notice the release test is indeed also optional - my bad. It could just be disabled for Beagle then - but do we ever want to do a "dry-run" of goreleaser during the CI flow 🤔

We could separate the goreleaser dry-run to a another workflow, i.e. prerelease or release-dryrun which only triggers on pushes to main. Then we can see whether a release would succeed before pushing a new tag, hopefully reducing "false" tags.

@alex5517
Copy link
Contributor

alex5517 commented Apr 29, 2025

@alex5517 wanted those goreleaser checks in CI. They are optional.

Ahh, yes, I notice the release test is indeed also optional - my bad. It could just be disabled for Beagle then - but do we ever want to do a "dry-run" of goreleaser during the CI flow 🤔

We could separate the goreleaser dry-run to a another workflow, i.e. prerelease or release-dryrun which only triggers on pushes to main. Then we can see whether a release would succeed before pushing a new tag, hopefully reducing "false" tags.

I am not a big fan of "hoping Kim waits for the CI to pass/fail on pushes to main..."

@alex5517
Copy link
Contributor

One way to ensure this could perhaps be with ruleset for tags that requires workflow to pass

@langecode
Copy link
Member Author

langecode commented Apr 29, 2025

But what are the odds of the goreleaser failing if the code compiles? It is primarily plumbing around compiling the code and putting it into Brew, container image, etc. isn't it?

The resources put into running this on every single push worth it?

@alex5517
Copy link
Contributor

@langecode
In regards to #15 the idea was also to verify other steps than go compile.
such as:

  • Errors in Dockerfiles
  • Problems during archiving
  • ...

But as @ChBLA suggested it could perhaps be fine with check on push to branch with PR target to default branch and then release --snapshot ... for pushes to main with a ruleset restricting tags before it passes.

@langecode
Copy link
Member Author

I'll merge this for now - then lets see what validation makes sense before doing a release.

@langecode langecode merged commit d7387a8 into main Apr 30, 2025
@langecode langecode deleted the feature/no-goreleaser-in-ci branch April 30, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not run goreleaser in CI

4 participants