Skip to content

Conversation

@dario-piotrowicz
Copy link

Summary

The Vike framework is not included in the build-info detection, so I'm adding it.

(My main reason for adding it here is that we want to support vike in Cloudflare's wrangler CLI auto-configuration logic which uses build-info under the hood for its framework detection logic)


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 6, 2025 21:58
@brillout
Copy link

brillout commented Dec 7, 2025

LGTM (I'm the creator of Vike).

Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Just one issue with the (client) publish dir.

Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants