Skip to content

Router: constructUrl respect port #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
f3l1x wants to merge 19 commits into from
Closed

Router: constructUrl respect port #10

f3l1x wants to merge 19 commits into from

Conversation

@f3l1x
Copy link
Member

@f3l1x f3l1x commented Oct 12, 2021 •
edited
Loading

dg and others added 19 commits February 8, 2021 06:41
@dg
opened 3.1-dev
1c79138
@dg
requires PHP 7.2
ec9f132
@dg
Route: uses loose comparison == for default values since PHP 8.0 [Closes
3f18fa0 
 nette#8]
@xificurk @dg
SimpleRouter: uses loose comparison == for default values since PHP 8.0
cd8d6cb
@dg
Route: refactoring
420c9cf
@dg
Route: ignores multiple /// [Closes nette#6]
30b313f
@dg
Route: rejects route when constant parameter is not present (BC break?)
b14ecce 
Not to generate the first URL for Homepage: default

$router->addRoute('/foo', [
    'presenter' => 'Homepage',
    'action' => 'default',
    'week' => 'upcoming',
]);
$router->addRoute('/', 'Homepage:default');
@dg
composer: updated dependencies
683d5c1
@dg
RouteList: added getDomain() & getPath()
94427ba
@dg
opened 4.0-dev
71a7bda
@dg
requires PHP 8.0
2d16dde
@dg
composer: updated dependencies
037922c
@dg
removed support for PHP 7
89bd06e
@dg
coding style
c2df051
@dg
added property typehints
9b8670e
@dg
added PHP 8 typehints
42a50c7
@dg
removed community health files
cae5eec
@dg
used native PHP 8 functions
af578eb
@f3l1x
Router: constructUrl respect port
343e579
@dg
Copy link
Member

dg commented Oct 12, 2021

This ip2long($host) needs to be called with host, the authority includes the port.

tomas-kulhanek
tomas-kulhanek reviewed Oct 12, 2021
View reviewed changes
src/Routing/Route.php
$host = $refUrl->getHost();
$host = $refUrl->getAuthority();
$parts = ip2long($host)
? [$host]
Copy link

@tomas-kulhanek tomas-kulhanek Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, calling $refUrl->getAuthority() this should be here

@f3l1x
Copy link
Member Author

f3l1x commented Oct 13, 2021

@dg Yep, I know. It's PoC if it's working like that. Should I continue on this and update ip2long?

@dg dg force-pushed the master branch 2 times, most recently from b03316b to a358a73 Compare December 12, 2021 17:16
@dg dg force-pushed the master branch 2 times, most recently from 92fe98e to e056319 Compare September 6, 2022 14:55
dg added a commit that referenced this pull request Jan 10, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
10078bc 
…ette/application#297]
dg added a commit that referenced this pull request Jan 10, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
242b297 
…ette/application#297]
dg added a commit that referenced this pull request Jan 10, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
74a9068 
…ette/application#297]
dg added a commit that referenced this pull request Jan 10, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
de242a3 
…ette/application#297]
dg added a commit that referenced this pull request Jan 18, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
8825750 
…ette/application#297]
dg added a commit that referenced this pull request Jul 30, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
6767463 
…ette/application#297]
dg added a commit that referenced this pull request Aug 5, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
1bcdc82 
…ette/application#297]
dg added a commit that referenced this pull request Sep 26, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
81b7f85 
…ette/application#297]
dg added a commit that referenced this pull request Oct 5, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
3138830 
…ette/application#297]
dg added a commit that referenced this pull request Oct 9, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
52e5061 
…ette/application#297]
dg added a commit that referenced this pull request Nov 13, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
719a6cf 
…ette/application#297]
dg added a commit that referenced this pull request Dec 11, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
1b5aba4 
…ette/application#297]
dg added a commit that referenced this pull request Dec 11, 2023
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
16b3c25 
…ette/application#297]
dg added a commit that referenced this pull request Jan 21, 2024
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
7d2581c 
…ette/application#297]
dg added a commit that referenced this pull request Jan 21, 2024
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
e25b781 
…ette/application#297]
dg added a commit that referenced this pull request May 2, 2024
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
af962de 
…ette/application#297]
dg added a commit that referenced this pull request Jun 18, 2024
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
2d7557b 
…ette/application#297]
dg added a commit that referenced this pull request Nov 4, 2024
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
1c929dd 
…ette/application#297]
dg added a commit that referenced this pull request Jun 5, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
fbc9b08 
…ette/application#297]
dg added a commit that referenced this pull request Jun 19, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
89c14e3 
…ette/application#297]
dg added a commit that referenced this pull request Jun 19, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
40d4bee 
…ette/application#297]
dg added a commit that referenced this pull request Aug 1, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
dcdafb4 
…ette/application#297]
dg added a commit that referenced this pull request Oct 30, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
aee4238 
…ette/application#297]
dg added a commit that referenced this pull request Oct 31, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
197b1cb 
…ette/application#297]
dg added a commit that referenced this pull request Dec 27, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
84b7dfc 
…ette/application#297]
dg added a commit that referenced this pull request Dec 27, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
1d31620 
…ette/application#297]
dg added a commit that referenced this pull request Dec 29, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
15c1f47 
…ette/application#297]
dg added a commit that referenced this pull request Dec 29, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
b21921a 
…ette/application#297]
dg added a commit that referenced this pull request Dec 30, 2025
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
58e7567 
…ette/application#297]
dg added a commit that referenced this pull request Jan 9, 2026
@dg
Route: added port to %host%, %domain%, %tld% WIP [Closes #10][Closes n…
d4c23e5 
…ette/application#297]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tomas-kulhanek tomas-kulhanek tomas-kulhanek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Route constructUrl incorrectly builds a URL on a non-standard port

4 participants

@f3l1x @dg @tomas-kulhanek @xificurk