added changes to make the input work correctly on Android#24
Open
sfanetti wants to merge 1 commit intonetworkteam:masterfrom
Open
added changes to make the input work correctly on Android#24sfanetti wants to merge 1 commit intonetworkteam:masterfrom
sfanetti wants to merge 1 commit intonetworkteam:masterfrom
Conversation
Open
Contributor
|
Hi Scott, thx. for this contribution. I'll test this ASAP and if it works in browsers I'm okay to change this - I don't have a physical Android right now (only Apples here). |
Author
|
Yeah - its not quite complete - I found some additional edge cases when
testing lower version of Android - I think I can get 8+ but 7 and lower are
not going to be in the cards.
…On Thu, Jul 27, 2023 at 2:55 PM Christopher Hlubek ***@***.***> wrote:
Hi Scott, thx. for this contribution. I'll test this ASAP and if it works
in browsers I'm okay to change this - I don't have a physical Android right
now (only Apples here).
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABTDI535VP7B3VWKJVFHUDXSK2T5ANCNFSM6AAAAAA2YWLLE4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
hlubek
approved these changes
Jul 28, 2023
Contributor
hlubek
left a comment
hlubek
left a comment
There was a problem hiding this comment.
Looks good by reading and testing in the browser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses the before input as a proxy for keypress that allows for Android input to work. Currently when you attempt to type in the input while in Android - the values do not get updated and the mask does not get displayed on input text types. If you use a tel or num type it seems to work. But text types do not receive events correctly.
Testing needs to happen on Browserstack or on a physical device so I do not have an automated way of doing this - but regressions do not seem to be a problem.