Conversation
glennmatthews
previously approved these changes
Dec 14, 2021
| def load(self, filename=COUNTRIES_FILE): # pylint: disable=arguments-differ | ||
| """Load all regions and countries from a local JSON file.""" | ||
| with open(filename, "r") as data_file: | ||
| with open(filename, "r") as data_file: # pylint: disable=unspecified-encoding |
Collaborator
There was a problem hiding this comment.
Can we just specify utf-8 as the encoding instead?
tasks.py
Outdated
| def project_ver(): | ||
| """Find version from pyproject.toml to use for docker image tagging.""" | ||
| with open("pyproject.toml") as file: | ||
| with open("pyproject.toml") as file: # pylint: disable=unspecified-encoding |
Collaborator
There was a problem hiding this comment.
utf-8 here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only update the lock file that we are using for testing so it shouldn't affect the end users of the library
In the process I had to change some code to align with the latest version of pylint