How do I get the NOTIFYMSG into the upssched-cmd script from the upsmon.conf

[markuswells]

In my upsmon.conf I have:

NOTIFYCMD /usr/sbin/upssched
NOTIFYMSG ONLINE        "UPS %s on - line power"
NOTIFYMSG ONBATT        "UPS %s on - battery"

NOTIFYFLAG ONLINE       SYSLOG+WALL+EXEC
NOTIFYFLAG ONBATT       SYSLOG+WALL+EXEC

Then in upssched.conf :

CMDSCRIPT /usr/local/bin/upssched-cmd

# Command pipe and lock-file
PIPEFN /run/nut/upssched.pipe
LOCKFN /run/nut/upssched.lock
# Send alerts immediately on change in line power
AT ONBATT * EXECUTE onbatt

I can print, but MSG does not pass forward. Its in the log from upssched, but I want the message to post in the email.

#!/bin/sh

case $1 in
  onbatt)
    printf "1:$UPSNAME 2:"$@" 3:$NOTIFYTYPE" >&2
    ;;
esac

I do not see the pre-defined message being passed through. If it not, can you consider adjusting the code?

[jimklimov]

Hello, I got a bit confused, looks like parts of text are missing?

Namely, this seems to imply your script gets the message from upsmon? right? Or does it only get the upsname and notifytype but not the string?

I can print, but MSG does not pass forward. Its in the log from upssched, but I want the message to post in the email.

In any case, script-wise, you'd need to pipe that printf to mailx or similar submission program, and drop the double-parentheses around $@ - you already have some for the message overall, so here you close them, add some text, and if it has white-spaces, your first arg to printf (formatting string) is finished, and args to substitute via percent-tokens begin. In fact, you may want $* instead (single token) and make fmt string explicit (so any percents in expanded values would never confuse it):

printf '1:%s 2:%s 3:%s\n' "$UPSNAME" "$*" "$NOTIFYTYPE"

[markuswells]

I define the message in upsmon.conf and it shows in the log. In the upssched-cmd I also printf stuff to the log:

UPS river3plus@0.0.0.0:3493 on - battery
1:river3plus@0.0.0.0:3493 2:onbatt 3:ONBATT

I do not want to define the message in 2 locations (upsmon.conf & upssched-cmd). Is there a way for upssched-cmd to get the message defined in upsmon.conf, like it does for $UPSNAME & $NOTIFYTYPE?
I have tried $NOTIFYMSG

[jimklimov]

Thanks for clarifying. I dug into that program recently for #3097.

So one thing first - getting this to work with timers (especially ones that are shared by several events like 4 UPSes matching AT * ... going on-battery at the same time) would be at best clumsy (e.g. a big comma-separated list of original messages that clumped together in one timer). This would probably not be so much of an issue with an horde of unique timers (where you have one UPS).

FWIW, some code is there for passing a second parameter to the called CMDSCRIPT, so maybe that can be used. Or envvars as they were.

[jimklimov]

Looking at upssched.c, its argv[1] does not seem to be going anywhere, so I guess is ignored indeed.

[jimklimov]

PR posted, testing welcome.