PyNUT "ListClients" method does not work

[clepple]

There seem to be a few related bugs in the PyNUT ListClients method, as of module version 1.3.0 (NUT 2.7.4+). The symptom is ERR INVALID-ARGUMENT.

• The command is LIST CLIENT +ups (no "S" at the end of "CLIENT")
• The "BEGIN" response includes the UPS name

Not sure if there are others.

[isudoi]

In the meantime I figured out away to report NUT client by simply running nestat to check connected/established connections

For count:

root@raspberrypi:/etc/nut# netstat -anp | grep :3493 | grep ESTABLISHED | wc -l
4

.
.
.
.

For details:

root@raspberrypi:/etc/nut# netstat -anp | grep :3493 | grep ESTABLISHED
tcp        0      0 127.0.0.1:3493          127.0.0.1:35496         ESTABLISHED 1896/upsd
tcp        0      0 127.0.0.1:35496         127.0.0.1:3493          ESTABLISHED 1910/upsmon
tcp        0      0 10.0.3.37:3493          10.0.12.201:46964       ESTABLISHED 1896/upsd
tcp        0      0 10.0.3.37:3493          10.0.3.16:60548         ESTABLISHED 1896/upsd          

[jimklimov]

Note that in the example above you account localhost twice (as server and as client). Technically that grep expression could also match e.g. port 34935.

Posting and testing a PR for PyNUT, to query the data server for its perspective, could be helpful though :)

Possibly extending the new (currently somewhat messy) tests/NIT/nit.sh to set up a sandbox with client(s) attached and listing those - the bug could be caught (and fix confirmed) this way...