Fix nut-scanner subnet/mask handling#1157
Merged
jimklimov merged 4 commits intonetworkupstools:masterfrom Nov 3, 2021
Merged
Conversation
…manipulating its memory buffer
aquette
approved these changes
Nov 3, 2021
jimklimov
force-pushed
the
fix-nut-scanner-subnet
branch
2 times, most recently
from
bdb8653 to
297d89b
Compare
jimklimov
force-pushed
the
fix-nut-scanner-subnet
branch
from
297d89b to
3a8fe31
Compare
|
This pull request introduces 1 alert when merging 3a8fe31 into a12302c - view on LGTM.com new alerts:
|
This was referenced Nov 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems that builds in recent OSes exposed that we manipulated free'd memory to parse CIDR string (indirectly - by saved pointers to sub-string contents behind
cidr_tok, such asmaskandsaveptr), and this no longer "happens to work".Freeing of
cidr_tokshould happen as late as it is appropriate.