Skip to content

Fix Windows v2.8.0 C++11 and cppunit builds#1596

Merged
jimklimov merged 34 commits intonetworkupstools:Windows-v2.8.0-1from
jimklimov:Windows-v2.8.0-cppunit
Aug 22, 2022
Merged

Fix Windows v2.8.0 C++11 and cppunit builds#1596
jimklimov merged 34 commits intonetworkupstools:Windows-v2.8.0-1from
jimklimov:Windows-v2.8.0-cppunit

Conversation

@jimklimov
Copy link
Copy Markdown
Member

@jimklimov jimklimov commented Aug 19, 2022

Closes: #1594

UPDATE:
Closes: #1598
Closes: #1603

@jimklimov jimklimov marked this pull request as ready for review August 19, 2022 20:42
@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@jimklimov
Copy link
Copy Markdown
Member Author

Sort of viable - builds, but needs more love for connections to actually work (missed something to port from upsclient.c? mixup of int and SOCKET struck after all? like #1592):

================================
[INFO] Call libnutclient test suite: cppnit with login credentials: simple admin
D: Getting test suite...
D: Preparing test runner...
D: Setting test runner outputter...
D: Launching the test run...
.[D] C++ NUT Client lib test running against Data Server at: localhost:34992
E.[D] Could not device list: Error while writing on socket
E.[D] Could not authenticate as a simple user: Error while writing on socket
[D] Could not log into primary device (envvars not set?) so test below should return empty client lists: Not connected
[D] Could not device client list: Not connected
E.[D] Could not authenticate as a simple user: Error while writing on socket
[D] Failed to set device variable: Not connected
E.[D] SKIPPING test_auth_primary()
##Failure Location unknown## : Error
Test name: nut::NutActiveClientTest::test_query_ver
uncaught exception of type std::exception (or derived).
- Error while writing on socket
##Failure Location unknown## : Error
Test name: nut::NutActiveClientTest::test_list_ups
uncaught exception of type std::exception (or derived).
- Not connected
##Failure Location unknown## : Error
Test name: nut::NutActiveClientTest::test_list_ups_clients
uncaught exception of type std::exception (or derived).
- Not connected
##Failure Location unknown## : Error
Test name: nut::NutActiveClientTest::test_auth_user
uncaught exception of type std::exception (or derived).
- Not connected
Failures !!!
Run: 5   Failure total: 4   Failures: 0   Errors: 4
D: Got to the end of test suite with code 'false'
[ERROR] cppnit complained, check above
[INFO] Stopping test daemons

@jimklimov jimklimov marked this pull request as draft August 19, 2022 21:49
@jimklimov jimklimov force-pushed the Windows-v2.8.0-cppunit branch from 8d75fb2 to 516514d Compare August 20, 2022 14:26
@AppVeyorBot
Copy link
Copy Markdown

@jimklimov jimklimov marked this pull request as ready for review August 21, 2022 11:31
@jimklimov
Copy link
Copy Markdown
Member Author

Now it connects and passes, one more checkbox off our backs :)

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@jimklimov jimklimov merged commit 589b7f2 into networkupstools:Windows-v2.8.0-1 Aug 22, 2022
@jimklimov jimklimov deleted the Windows-v2.8.0-cppunit branch August 22, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants