drivers/libusb1.c: nut_libusb_open(): do not keep Bus/Device/BusPort…#2114
Merged
jimklimov merged 1 commit intonetworkupstools:masterfrom Oct 17, 2023
Merged
drivers/libusb1.c: nut_libusb_open(): do not keep Bus/Device/BusPort…#2114jimklimov merged 1 commit intonetworkupstools:masterfrom
jimklimov merged 1 commit intonetworkupstools:masterfrom
Conversation
…pointers to random malloc() block if we did not get a number to print there from libusb Avoid (un-)pretty prints like: 0.031364 [D2] - Bus: 006 0.031366 [D2] - Bus Port: ▒UV▒▒U 0.031368 [D2] - Device: 001 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
the
impacts-release-2.8.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pointers to random malloc() block if we did not get a number to print there from libusb(-1.0)
Avoid (un-)pretty prints like:
The problem seems to be introduced only with
libusb1.c, not withlibusb0.cnortools/nut-scanner/scan_usb.c(where such reports are collected differently), so can be considered a fallout of #300.It happens when the platform can not report a useful number (so was not noticed until introduction of
busporthandling with #2054, but the same pattern related to earlier Bus and Device number handling too).