Skip to content

m4/nut_compiler_family.m4: fix cross-compilation#2146

Merged
jimklimov merged 1 commit intonetworkupstools:masterfrom
ffontaine:master
Nov 5, 2023
Merged

m4/nut_compiler_family.m4: fix cross-compilation#2146
jimklimov merged 1 commit intonetworkupstools:masterfrom
ffontaine:master

Conversation

@ffontaine
Copy link
Copy Markdown
Contributor

Do not use isystem with host paths when cross-compiling

Do not use isystem with host paths when cross-compiling

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@jimklimov
Copy link
Copy Markdown
Member

Thanks, looks reasonable. Assuming cross_compiling gets set when applicable? Did you check it works for actual cross builds?

So far one I had experience with was linux+mingw to build for windows, and as much as codified in those helper scripts - it worked...

@ffontaine
Copy link
Copy Markdown
Contributor Author

Yes, it works under buildroot and allows to drop an "ugly" hack

@jimklimov jimklimov added this to the 2.8.2 milestone Nov 5, 2023
@jimklimov jimklimov added CI Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes) cross-builds portability We want NUT to build and run everywhere possible labels Nov 5, 2023
@jimklimov jimklimov merged commit ec256e0 into networkupstools:master Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes) cross-builds portability We want NUT to build and run everywhere possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants