usbhid-ups: allow to throttle or suppress logged messages about OL+DISCHRG situation#2216
Merged
jimklimov merged 3 commits intonetworkupstools:masterfrom Dec 10, 2023
Merged
Conversation
…onlinedischarge" in favor of "onlinedischarge_onbattery" option name [networkupstools#2213] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…onlinedischarge_log_throttle_sec" setting and/or throttling by changes of battery.charge [networkupstools#2214] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…onlinedischarge_log_throttle_hovercharge" setting [networkupstools#2215] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
the
ready / code review
This was referenced Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1970
Closes: #2212
Closes: #2213
Closes: #2214
Closes: #2215
Introduces a number of new configurable toggles with hopefully reasonable defaults, which should help to reduce log noise on systems where an UPS reports "online" and "discharging" simultaneously (so far some CyberPower and APC models were reported to behave so, with different physical situations).