Eaton: add support for EMP002 on ATS16 NM2 with SNMP#2286
Merged
jimklimov merged 1 commit intonetworkupstools:masterfrom Jan 29, 2024
Merged
Eaton: add support for EMP002 on ATS16 NM2 with SNMP#2286jimklimov merged 1 commit intonetworkupstools:masterfrom
jimklimov merged 1 commit intonetworkupstools:masterfrom
Conversation
This support is identical to what is in Eaton Marlin and Powerware MIBs. Future improvements should consider putting these bits in a common eaton-sensor-mib file, to avoid multiple definition of the same MIB structure! Imported from DMF branch (with reductions for main trunk) from commit 40c883f Signed-off-by: Arnaud Quette <ArnaudQuette@eaton.com>
arnaudquette-eaton
approved these changes
Jan 29, 2024
Contributor
arnaudquette-eaton
left a comment
arnaudquette-eaton
left a comment
There was a problem hiding this comment.
LGTM, though not checked deep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This support is identical to what is in Eaton Marlin and Powerware MIBs. Future improvements should consider putting these bits in a common eaton-sensor-mib file, to avoid multiple definition of the same MIB structure!
Imported from FTY fork / DMF branch (with reductions for main trunk) from commit 40c883f
Originally by @aquette
NOTE: After merge of other contemporary PRs, this code would welcome wrappings from #2285 (available in #2275 which is where these not-upstreamed lines were "discovered").