Skip to content

configure.ac: revise detection of LN_S_R method applicable for the build (out-of-tree concerns)#2322

Merged
jimklimov merged 3 commits intonetworkupstools:masterfrom
jimklimov:configure-ln-s-r
Feb 28, 2024
Merged

configure.ac: revise detection of LN_S_R method applicable for the build (out-of-tree concerns)#2322
jimklimov merged 3 commits intonetworkupstools:masterfrom
jimklimov:configure-ln-s-r

Conversation

@jimklimov
Copy link
Copy Markdown
Member

@jimklimov jimklimov commented Feb 27, 2024

In some build recipes we use symbolic- or hard-linking of files (e.g. DIST'ed resources) and originally had a fallback to ln if relative ln -s -r was not available. This fallback did not work when source and build areas (the most typical use-cases) are on different filesystems (e.g. under /home and /tmp) - with this PR, fall back to full copy would be used instead.

Follows up from #2318 work.

NOTES:

  • This macro is not actually used in current Makefiles of the master branch so far, but perhaps should be (especially for other out-of-tree concerns, like that with text sources for docs per Fix make docs for runs made completely out-of-tree #2318). It is used in DMF/FTY branches that slowly converge towards getting upstreamed, however. And now that a deficiency in the macro already present in the main codebase is known, fixing it is prudent anyway.
  • TODO: Consider install-sh like autotools does for some cases?

UPDATE: Also added CI_FAILFAST support for ci_build.sh part about building in parallel and retrying sequentially upon failures. Unrelated, but won't hurt to pass through CI in one shot :)

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov added CI Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes) refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings portability We want NUT to build and run everywhere possible DMF NUT Data/Dynamic Mapping File/Format/Functionality feature labels Feb 27, 2024
@jimklimov jimklimov added this to the 2.8.2 milestone Feb 27, 2024
…ntial build_to_only_catch_errors_target() logic - ensure parallel builds succeed "as is"

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…plementation

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov merged commit 6095dea into networkupstools:master Feb 28, 2024
@jimklimov jimklimov deleted the configure-ln-s-r branch February 28, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Entries related to continuous integration infrastructure (here CI = tools + scripts + recipes) DMF NUT Data/Dynamic Mapping File/Format/Functionality feature portability We want NUT to build and run everywhere possible refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant