Conjure up config.h header guards and improve search for shared libs#2329
Merged
jimklimov merged 5 commits intonetworkupstools:masterfrom Mar 1, 2024
Merged
Conversation
jimklimov
added
CI
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
force-pushed
the
config-header-guards
branch
from
15baa36 to
d31b8c2
Compare
...on systems that only support it partially Courtesy of https://stackoverflow.com/a/65125295/4715872 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ame (if any), if got no hits Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
changed the title
config.h header guardsconfig.h header guards and improve search for shared libs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
include/config.his sourced by many programs explicitly, and by some implicitly viacommon.hor other headers.Since autotools generates it without a header guard, this is wasteful in terms of processing, and causes conflicts when certain test code carefully re-defines some of the configured values and then another header pulls in
config.hagain with a now-differently defined value.This PR adds use of
#ifndef NUT_NETVERSIONin consuming NUT internal headers as a sort of header guard for#include "config.h"directive there, to avoid double-processing.Other commits fix:
make docsfor runs made completely out-of-tree #2318 makefile comment changes;pipfor older Python releases