clients/upsclient.h: include sys/types.h#2475
Merged
jimklimov merged 1 commit intonetworkupstools:masterfrom Jun 25, 2024
ffontaine:master
Merged
clients/upsclient.h: include sys/types.h#2475jimklimov merged 1 commit intonetworkupstools:masterfrom ffontaine:master
jimklimov merged 1 commit intonetworkupstools:masterfrom
ffontaine:master
Conversation
Include sys/types.h to avoid the following uclibc build failure with collectd raised since version 2.8.0 and 3f3851e: configure:109633: checking int type of port argument for NUT upscli_splitname configure:109665: /home/buildroot/instance-0/output-1/host/bin/x86_64-linux-gcc -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g0 -Wall -Werror -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5 In file included from conftest.c:172: /home/buildroot/instance-0/output-1/host/x86_64-buildroot-linux-uclibc/sysroot/usr/include/upsclient.h:114:1: error: unknown type name 'ssize_t'; did you mean 'size_t'? 114 | ssize_t upscli_sendline_timeout(UPSCONN_t *ups, const char *buf, size_t buflen, const time_t timeout); | ^~~~~~~ | size_t Fixes: - http://autobuild.buildroot.org/results/205/2058f87ad7dbf7fbc62c8747855c82da4157ea35/collectd-5.12.0/config.log Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
jimklimov
added
bug
portability
Member
|
Good catch, thanks! Would you please share how such builds with alternative libc (uclibc, maybe musl) can be arranged for NUT CI farm builds? (Maybe buildroots are ok, maybe prepared LXC containers or some such to reduce R/W traffic for dependencies involved) |
Contributor
Author
|
I'm not familiar with CI but you could probably try to reuse what buildroot is using with gitlab CI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
sys/types.hto avoid the following uclibc build failure with collectd raised since version 2.8.0 and3f3851e:
Fixes: