Remember shared-object file names seen during build for later run-time dlopen() preference#2504
Merged
jimklimov merged 10 commits intonetworkupstools:masterfrom Jul 3, 2024
Merged
Conversation
…logic once Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…etworkupstools#2431] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…* for nut-scanner third-party libs [networkupstools#2431] libavahi, libfreeipmi, libneon, libnetsnmp, libusb0/1 NOTE: The libnutclient is separate, we build it - so can not detect the final name in advance right here Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…MacOS Darwin "*.dylib" extension [networkupstools#2431] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ame` includes path separator character(s) [networkupstools#2431] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…pdate comments [networkupstools#2431] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…networkupstools#2431] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…H_LIB discovered libraries [networkupstools#2431] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
packaging
nut-scanner
portability
…ify packaging [networkupstools#2431] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…en discovering libraries [networkupstools#2431] At least MacOS with Homebrew seems puts each packaged library into its own directory, so args like `-L/opt/homebrew/Cellar/neon/0.32.5/lib` would be required for successful discovery. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This was referenced Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows to remember string values of library names (and full paths) seen during build, and prefer them over bland
libsomething.sosymlinks which may be not even available in non-dev packages on some systems. Addresses most of issue #2431One remaining bit is the name of our own
libupsclient.so/dll/...Maybe the logic put into
m4now should become a standalone shell script, to generate a#defineone-line header after we build our library?..This should also be applied to DMF branch (loads more libs in other code paths).