Implement parallel IPMI scanning in nut-scanner, and address some valgrind complaints#2528
Merged
jimklimov merged 18 commits intonetworkupstools:masterfrom Jul 11, 2024
Merged
Conversation
jimklimov
added
bug
enhancement
nut-scanner
CI
…r.c, NEWS.adoc: implement parallel scanning for remote IPMI controllers [networkupstools#2523] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…pstools#2511] * Clearly name "thread-ready" scanning methods that can be used standalone or from pthread_create() constraints * Settle on "thready" methods freeing caller's data (so we do not worry about doing it after the parallel loops, or at a wrong moment before) * Unify code mark-up in the files to facilitate later comparisons * Update some comments Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…age [networkupstools#2511] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…mment what we do about "dirname" with and without realpath() support Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…() the loaded library modules [networkupstools#2511] Avoid some memory leak reports Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…rack semaphore usage in debugger Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…looked before Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…t_snmp() once per library load [networkupstools#2511] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…tions more reliably [networkupstools#2511] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…FD leak [networkupstools#2511] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…rain libnetsnmp leak reports [networkupstools#2511] It seems that although `init_snmp()` is called once, every use of the library initializes some data which it then does not release, at least on the test system here. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…s/valgrind/.valgrind.supp: constrain warnings about library methods [networkupstools#2511] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…rain warnings about library methods [networkupstools#2511] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…evise trace-logging and comment markup [networkupstools#2511] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…upstools#2511] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ementations [networkupstools#2511] Per https://forums.freebsd.org/threads/named-semaphore-uninitialized-bytes.84850/ apparently BSD libc and GLibc at least do suffer Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #2511
Closes: #2523