Neuter our PACKAGE_URL in SNMP code builds#2563
Merged
jimklimov merged 5 commits intonetworkupstools:masterfrom Jul 29, 2024
Merged
Neuter our PACKAGE_URL in SNMP code builds#2563jimklimov merged 5 commits intonetworkupstools:masterfrom
PACKAGE_URL in SNMP code builds#2563jimklimov merged 5 commits intonetworkupstools:masterfrom
Conversation
… avoid conflict with net-snmp-config.h [networkupstools#1949] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…lict with net-snmp-config.h [networkupstools#1949] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
packaging
SNMP
CI
…in the loop [networkupstools#1949] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…upstools#1949] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…f present [networkupstools#1949] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jul 29, 2024
…tworkupstools#1949] Merge branch 'issue-1949-url' as PR networkupstools#2563 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #2554 for issue #1949. Headers from libnetsnmp declare their autoconf macro values directly, conflicting with ones we define ourselves for NUT, so historically we
undefed them before SNMP code builds. Now that we deliverPACKAGE_URL, gotta handle it similarly.