Skip to content

Ecomode-auto-addon-todo#2949

Merged
jimklimov merged 7 commits intonetworkupstools:masterfrom
masterwishx:ecomode-auto-addon-todo
May 13, 2025
Merged

Ecomode-auto-addon-todo#2949
jimklimov merged 7 commits intonetworkupstools:masterfrom
masterwishx:ecomode-auto-addon-todo

Conversation

@masterwishx
Copy link
Copy Markdown
Contributor

Signed-off-by: DaRK AnGeL 28630321+masterwishx@users.noreply.github.com

To continue work for #2947 :

To make automatic ECO Mode variable or command experimental.ecomode.start.auto and experimental.ecomode.stop.auto
that run Bypass On then ECO Mode Enable and back instead of users are run two separate commands or variables :

bypass.start + experimental.ecomode.enable
bypass.stop + experimental.ecomode.disable

or

 Enable bypass mode:
upsrw -u admin -p pass -s input.bypass.switch.on=on eaton

Enable ECO mode:
upsrw -u admin -p pass -s input.eco.switchable=enable eaton

Disable bypass mode:
upsrw -u admin -p pass -s input.bypass.switch.off=off eaton

Disable ECO mode:
upsrw -u admin -p pass -s input.eco.switchable=normal eaton

…t argument for bypass and ecomode cmds

Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
…ed) to "input.bypass.switch.off", "off" ,aded function of eaton_input_bypass_check_range(value); , eaton_input_eco_mode_check_range(value);

Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
… compiled

Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
Signed-off-by: DaRK AnGeL <28630321+masterwishx@users.noreply.github.com>
@jimklimov jimklimov added the ECO/ESS/HE/ABM modes Non-trivial power supply management modes (ECO, ESS, HE, ABM etc.) label May 11, 2025
@jimklimov jimklimov merged commit 4c88b3c into networkupstools:master May 13, 2025
47 of 49 checks passed
@jimklimov jimklimov added this to the 2.8.4 milestone May 13, 2025
@jimklimov
Copy link
Copy Markdown
Member

@masterwishx : note - this PR got auto-merged with #2947, apparently it was same or subset of that. Was this intended, or did you plan some more work separately from that change?

@masterwishx
Copy link
Copy Markdown
Contributor Author

masterwishx commented May 13, 2025

@masterwishx : note - this PR got auto-merged with #2947, apparently it was same or subset of that. Was this intended, or did you plan some more work separately from that change?

Ohh sorry, yep we need more tests and some work maybe for ecomode auto.

I just made new pr from old one #2947 where I changed back to NULL for cmd and deleted all stuff for ecomode auto for continue to work here :(

@jimklimov
Copy link
Copy Markdown
Member

I see. Well, I guess now a new PR is in order to deliver logically named/typed commands. :)

@masterwishx
Copy link
Copy Markdown
Contributor Author

I see. Well, I guess now a new PR is in order to deliver logically named/typed commands. :)

Do you mean again to make pr for clean ecomode auto and move it to second new pr?

@jimklimov
Copy link
Copy Markdown
Member

Well... whatever commits were out there, tested by you and @ZivertX in #2947, they were merged and this PR got closed too: 2947 included this PR's chain of commits plus 6cfd10d.

So any other work (if planned) should get done as another PR :)

@masterwishx
Copy link
Copy Markdown
Contributor Author

Well... whatever commits were out there, tested by you and @ZivertX in #2947, they were merged and this PR got closed too: 2947 included this PR's chain of commits plus 6cfd10d.

So any other work (if planned) should get done as another PR :)

Yep, already made #2956 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ECO/ESS/HE/ABM modes Non-trivial power supply management modes (ECO, ESS, HE, ABM etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants