libusb{0,1}: if the tried "rdlen" did not succeed, fall back to the other value we had in mind#3149
Merged
jimklimov merged 6 commits intonetworkupstools:masterfrom Nov 7, 2025
Merged
Conversation
…d, fall back to the other value we had in mind [networkupstools#3136] In libusb1.c also fix printout of rdlen variables from %d to %PRIi32 Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ext_device" now that we have a loop and "continue" to try another rdlen [networkupstools#3136] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
❌ Build nut 2.8.4.3649-master failed (commit cf61981b21 by @jimklimov) |
Member
Author
|
Alas, can't fully check the PR myself. The driver still works, but (also without the PR changes) the Eaton Ellipse PRO 650 returns same |
Member
Author
|
Bumped the PR to sync with other improvements recently merged to |
Contributor
|
Just heard back from the 9PX user, it works for them now. Many thanks for the patch and patience. |
Member
Author
|
Great to hear, thanks! Driver startup logs to see it trying one option and retrying with another would be great too :) |
Contributor
|
Here we go: (sent from mobile, sorry about formatting) |
Member
Author
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3136
In libusb1.c also fix printout of rdlen variables from %d to %PRIi32
CC @desertwitch - can you get this tested please? :)