Improve cppunit and C++11 support via configure.ac#480
Merged
clepple merged 2 commits intonetworkupstools:masterfrom Oct 8, 2017
Merged
Improve cppunit and C++11 support via configure.ac#480clepple merged 2 commits intonetworkupstools:masterfrom
clepple merged 2 commits intonetworkupstools:masterfrom
Conversation
jimklimov
force-pushed
the
cppunit
branch
4 times, most recently
from
a6a0ea3 to
fb3faf4
Compare
Member
Author
|
Note; newer autoconf includes macros for this, but systems I've played with lack them. So iterated back to stone ax which just works ;) |
jimklimov
changed the title
* Detect C++11 support and its use for CPPUNIT tests through configure.ac - should address issue networkupstools#472 * Report after detecting C++11 support, presence of libcppunit, and request for valgrind, whether we'd build the cppunit tests * Update relevant comments in configure.ac
jimklimov
changed the title
jimklimov
added
ready / code review
Member
Author
|
Fixed a few wrinkles in the PR - now it does actually build and run the Alternately, if the script determines that the test code is not buildable, it won't try to do so and thus blow up the build. This PR is somewhat orthogonal to the embryotic state that the actual C++ test code is in. |
Member
|
I would also agree that merging this should close #472. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #472 and #366 and #466