Add support for Hunnox HNX-850 by marianojan · Pull Request #638 · networkupstools/nut

marianojan · 2018-12-01T20:44:45Z

This PR adds support for the Hunnox HNX-850 UPS.

It's a special case for the fabula subdriver, with a required lockstep for the commands. For this UPS, if the commands are not sent in a specific order, the output status remains unchanged.

To make it work, my ups.conf file, has the following configuration:

[u1]
       driver = "nutdrv_qx"
       port = "auto"
       vendorid = "0001"
       productid = "0000"
       protocol = hunnox
       langid_fix = 0x0409
       novendor
       noscanlangid

Also I had to add a new flag, noscanlangid because this scan hangs the USB endpoint of the UPS.

I hope it can help someone else who has this brand of UPS.

zykh · 2018-12-03T00:45:41Z

Thanks for the patch, @marianojan.
I'm not lucid enough and I've not enough time now for a complete review, but I'll come back to this in a few days...

So just one thing for now... basically the working sequence is:

initialization (only once):
- get string at index 0 twice,
- then string at index 1,
- then sleep for a while,
update sequence (loop):
- get string at index 0xd (F query),
- get string at index 3 (Q1 query),
- get string at index 0xc (I query),

right?

marianojan · 2018-12-03T12:17:36Z

Hello @zykh!

You are right, the working sequence is as you expressed it.
The initialization steps are required only once, as far as I tested it.
The update sequence requires that before each Q1 query, one of F or I query has to be done. I copied the steps from the Windows client, by capturing the requests with Wireshark.
Both the I and F queries return null data. (The windows client somehow receives a versión number, but when I tested in linux, I always got an empty string)

I don't have a great knowledge about the project, so if something is misplaced or has to be done in another way, please tell me.

Thank you for taking a look at it!

panoti · 2019-09-06T03:12:19Z


 /* Fabula communication subdriver */
-static int	fabula_command(const char *cmd, char *buf, size_t buflen)
+static int	_fabula_command(const char *cmd, char *buf, size_t buflen, char hunnox_patch)


I think it is not worth adding a hunnox_patch parameter which is only for Hunox 850. A function should be use for other protocols. Do you have any other options?

I thought that duplicating the entire function was a bad idea. But maybe it's the safest way to avoid problems for other UPSs? What do you recommend?

My stance on this wavered over time, but in the end I guess making an explicit "hunnox_command" that happens to repeat some of the other code can be more readable and maintainable, and would clearly "protect" support of different devices from these and later changes in not-their subdriver.

It may be or not be possible and practical that shared code can be de-duplicated into new routines called from various places, as a separate effort.

panoti

I have a ARES AR265i. It may also use this subdriver. I hope this pull request be merged.

knoid · 2020-02-12T13:42:00Z

Thanks to this PR I was able to get data from my newly bought UPS!

I'm not sure which model it really is but it's sold as "Ups Energit Iron Guardian 800 Plcd Dispay Usb Monofasica" (with spelling errors and all) and comes with software branded as "UPSmart v1.5" for redhat and I 1) don't own a CD-R and 2) use Ubuntu.

microfrost1 · 2020-05-04T09:37:17Z

This worked perfectly for my "Powercool Smart UPS 1200VA".

jimklimov · 2020-11-07T22:23:03Z

Was this work done by/for/on-behalf of a vendor (e.g. Hunnox)? If so, please update the docs/acknowledgements.txt file as well.

drivers/nutdrv_qx.c: rectify indentations

jimklimov · 2020-11-07T22:27:56Z

@@ -0,0 +1,29 @@
+/* nutdrv_qx_zinto.h - Subdriver for Zinto protocol based UPSes


@marianojan : if this was adapted from a subdriver for another UPS model, worth mentioning taht but the title here should point to Hunnox ;)

jimklimov · 2020-11-07T22:28:04Z

@@ -0,0 +1,137 @@
+/* nutdrv_qx_zinto.c - Subdriver for Zinto protocol based UPSes


@marianojan : if this was adapted from a subdriver for another UPS model, worth mentioning taht but the title here should point to Hunnox ;)

LukePrior · 2021-04-19T04:40:36Z

Is this going to get merged?

Updated file heading

Err on the safer side of changing behavior for non-hunnox device support, limit the applicability of langid_fix (per PR networkupstools#638 review cautionary comments). Maybe the proposed original change did apply to other devices that support the fix-up, but that should be evaluated separately and this new constraint reversed if needed.

Basically mention updates from Hunnox subdriver and protocol addition (PR networkupstools#638).

Some more keywords to the dictionary from PR networkupstools#638

jimklimov · 2021-04-20T08:02:39Z

Thanks @marianojan for the contribution and @panoti for review and highlighting possible sore points.

…mand() without using a mixed routine, to ensure no impact on currently supported devices

… choice of usb_get_string{,_simple}() based on langid_fix alone

…d to support more than Hunnox branded devices

…r (and use of) "hunnox_patch" leaving the markers in comments for refactoring

…g the buflen to 102 bytes

…la-hunnox" to "hunnox"

… PR networkupstools#638 for "hunnox" support

…(USB protocol subdriver vs. "hunnox_subdriver" for device data mapping)

jimklimov · 2021-04-23T14:21:25Z

+
+	{ "device.mfr",			0,	NULL,	"FW?\r",	"",	39,	'#',	"",	1,	15,	"%s",	QX_FLAG_STATIC | QX_FLAG_TRIM,	NULL,	NULL,	NULL },
+	{ "device.model",		0,	NULL,	"FW?\r",	"",	39,	'#',	"",	17,	26,	"%s",	QX_FLAG_STATIC | QX_FLAG_TRIM,	NULL,	NULL,	NULL },
+	{ "ups.firmware",		0,	NULL,	"FW?\r",	"",	39,	'#',	"",	28,	37,	"%s",	QX_FLAG_STATIC | QX_FLAG_TRIM,	NULL,	NULL,	NULL },


@aquette: going over recent merges, and given your earlier comments about mfr/model/serial in #807 (comment) - should these fields here be removed also (does something else handle them by default)? And/or apply some same namespace (ups vs device) here?

JulyIghor · 2021-06-20T16:08:41Z

Anyone knows what does mean '*' which sometimes comes instead of '('?

JulyIghor · 2021-06-22T15:41:29Z

Sometimes it won't start

  0.118743	[D3] nut_usb_set_altinterface: skipped usb_set_altinterface(udev, 0)
   0.120429	[D3] send: Q1
   0.124323	[D3] read: Input/output error (-5)
   0.124355	[D2] qx_process_answer: short reply (input.voltage)
   0.124377	[D2] Skipping protocol Q1 0.07
   0.124385	Device not supported!
   0.124395	Device not supported!

And works again only after re-attaching usb cable

…driver) (USB) [networkupstools#638]

Add support for Hunnox HNX-850

88ad313

marianojan force-pushed the hunnox-hnx850 branch from d8eaf12 to 88ad313 Compare December 1, 2018 22:00

zykh mentioned this pull request Mar 18, 2019

UPS DigiTECH Computer 650VA Not Supported #674

Closed

zykh mentioned this pull request Jul 30, 2019

weird behaviour when switching PC's #721

Closed

panoti reviewed Sep 6, 2019

View reviewed changes

Comment thread drivers/Makefile.am Outdated

Comment thread drivers/nutdrv_qx.c

Comment thread drivers/nutdrv_qx.c

clepple mentioned this pull request Jan 9, 2020

NSYS E series not supported #754

Open

Merge branch 'master' into hunnox-hnx850

b6a1559

This comment has been minimized.

Sign in to view

Merge branch 'master' into hunnox-hnx850

a1988c0

jimklimov reviewed Nov 7, 2020

View reviewed changes

Comment thread drivers/nutdrv_qx_hunnox.c

jimklimov reviewed Nov 7, 2020

View reviewed changes

Comment thread drivers/nutdrv_qx_hunnox.h

jimklimov and others added 2 commits November 7, 2020 23:23

Merge branch 'master' into hunnox-hnx850

182e4b4

Update nutdrv_qx.c

7856291

drivers/nutdrv_qx.c: rectify indentations

jimklimov requested changes Nov 7, 2020

View reviewed changes

Merge branch 'master' into hunnox-hnx850

8b5ae7a

clepple added the USB label Dec 31, 2020

Merge branch 'master' into hunnox-hnx850

8d7d108

jimklimov mentioned this pull request Apr 19, 2021

PowerCool VA1500 and nutdrv_qx #537

Closed

jimklimov added 2 commits April 19, 2021 22:04

Update nutdrv_qx_hunnox.h

33d7623

Updated file heading

Update nutdrv_qx_hunnox.c

0742857

Updated file heading

jimklimov approved these changes Apr 19, 2021

View reviewed changes

Comment thread drivers/nutdrv_qx.c

jimklimov added 2 commits April 19, 2021 22:15

Update nutdrv_qx.txt

364025d

Basically mention updates from Hunnox subdriver and protocol addition (PR networkupstools#638).

Update nut.dict

fc91bd4

Some more keywords to the dictionary from PR networkupstools#638

This comment has been minimized.

Sign in to view

networkupstools deleted a comment from lgtm-com Bot Apr 20, 2021

jimklimov mentioned this pull request Apr 20, 2021

nutdrv_qx: add support for SNR-UPS-LID-XXXX #1008

Merged

jimklimov added 7 commits April 20, 2021 10:16

docs/nut.dict: typo fix

672cfdb

drivers/nutdrv_qx.c: separate fabula_command_hunnox() from fabula_com…

c78fd72

…mand() without using a mixed routine, to ensure no impact on currently supported devices

drivers/nutdrv_qx.c: fabula_command_hunnox(): restore originally PRed…

414e5ef

… choice of usb_get_string{,_simple}() based on langid_fix alone

drivers/nutdrv_qx.c: comment that fabula_hunnox_subdriver was reporte…

d20de6c

…d to support more than Hunnox branded devices

drivers/nutdrv_qx.c: fabula_command_hunnox(): comment away scoping fo…

cbbfd2d

…r (and use of) "hunnox_patch" leaving the markers in comments for refactoring

drivers/nutdrv_qx.c: fabula_command_hunnox(): comment about truncatin…

cab025b

…g the buflen to 102 bytes

drivers/nutdrv_qx.c: restore indentation with TABs

342113c

This comment has been minimized.

Sign in to view

jimklimov added 3 commits April 20, 2021 11:11

drivers/nutdrv_qx.c: simplify new subdriver/command naming from "fabu…

88c77de

…la-hunnox" to "hunnox"

drivers/nutdrv_qx.c: bump core DRIVER_VERSION to reflect changes from…

ec09431

… PR networkupstools#638 for "hunnox" support

drivers/nutdrv_qx.c: fix back the name for "fabula_hunnox_subdriver" …

9872276

…(USB protocol subdriver vs. "hunnox_subdriver" for device data mapping)

This comment was marked as duplicate.

Sign in to view

jimklimov merged commit 169b637 into networkupstools:master Apr 20, 2021

jimklimov reviewed Apr 23, 2021

View reviewed changes

Yellow-Horror mentioned this pull request Jun 20, 2021

Upsilon 2000 values never updated (Crown CMU-SP1200IEC USB) #1014

Closed

Yellow-Horror mentioned this pull request Jun 21, 2021

'hunnox' protocol of 'nutdrv_qx' don't work in XigmaNAS (FreeBSD) #1049

Closed

jimklimov added the HCL label Apr 25, 2022

jimklimov added a commit to jimklimov/nut that referenced this pull request Apr 25, 2022

driver.list.in: Add HCL info for Hunnox devices (and new protocol sub…

93eea02

…driver) (USB) [networkupstools#638]

		@@ -0,0 +1,29 @@
		/* nutdrv_qx_zinto.h - Subdriver for Zinto protocol based UPSes

		@@ -0,0 +1,137 @@
		/* nutdrv_qx_zinto.c - Subdriver for Zinto protocol based UPSes

Uh oh!

Conversation

marianojan commented Dec 1, 2018

Uh oh!

zykh commented Dec 3, 2018

Uh oh!

marianojan commented Dec 3, 2018

Uh oh!

panoti Sep 6, 2019

Choose a reason for hiding this comment

Uh oh!

marianojan Sep 18, 2019

Choose a reason for hiding this comment

Uh oh!

jimklimov Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

panoti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

knoid commented Feb 12, 2020

Uh oh!

microfrost1 commented May 4, 2020

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

jimklimov commented Nov 7, 2020

Uh oh!

jimklimov Nov 7, 2020

Choose a reason for hiding this comment

Uh oh!

jimklimov Nov 7, 2020

Choose a reason for hiding this comment

Uh oh!

LukePrior commented Apr 19, 2021

Uh oh!

Uh oh!

This comment has been minimized.

jimklimov commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as duplicate.

jimklimov Apr 23, 2021

Choose a reason for hiding this comment

Uh oh!

JulyIghor commented Jun 20, 2021

Uh oh!

JulyIghor commented Jun 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jimklimov commented Apr 20, 2021 •

edited

Loading