Do not shutdown if UPS is performing calibration#817
Merged
jimklimov merged 2 commits intonetworkupstools:masterfrom Oct 7, 2020
Merged
Do not shutdown if UPS is performing calibration#817jimklimov merged 2 commits intonetworkupstools:masterfrom
jimklimov merged 2 commits intonetworkupstools:masterfrom
Conversation
Some UPS calibration procedures (e.g. CyberPower) involve discharging the battery below the LB level, but we don't want systems to shut down if the UPS is only on battery because it is calibrating.
jimklimov
reviewed
Oct 7, 2020
Log a warning if an UPS is both OB+LB+Calibrating so due to this combo we do not tell the host to shut down gracefully. Comment some ideas to work around such situation in a smarter way if we have additional info to know if we are in a safe environment just calibrating, or a known-unsafe one with a real outage in progress.
jimklimov
approved these changes
Oct 7, 2020
|
This pull request introduces 1 alert when merging 6b43dbb into 979d583 - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some UPS calibration procedures (e.g. CyberPower) involve
discharging the battery below the LB level, but we don't
want systems to shut down if the UPS is only on battery
because it is calibrating.