Pijuice cleanup#822
Merged
jimklimov merged 15 commits intonetworkupstools:masterfrom Oct 7, 2020
Merged
Conversation
Add pijuice driver
Update the driver Makefile.am to add pijuice driver to the LINUX_I2C_DRIVERLIST
Check for both the i2c-tools 3.x and 4.x include files (i2c-dev.h/smbus.h) and set flags accordingly. Link with the i2c library file from i2c-tools 4.x if it is available.
Update asem.c to complie cleanly by adding an include for <sys/ioctl.h>
Clean up the upsdebugX() labels Pull the conditional I2C support code closer to the includes block Don't report battery temp as UPS temp Warn if we adjust shutdown_delay
Accommodate one more variation of SMBUS/I2C support where both the headers and the libraries exist and are usable.
Check for I2C_FUNC_I2C to avoid errors caused by conflicts between linux/i2c-dev.h and linux/i2c.h
|
This pull request introduces 2 alerts when merging 5ac96a6 into 830876c - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up from #730 to solve its PR-merging nits.