Fightwarn fallthrough questionable - upscode2#846
Merged
jimklimov merged 1 commit intonetworkupstools:masterfrom Nov 11, 2020
Merged
Conversation
…so far consider it explicitly desired as it was before
jimklimov
changed the title
|
This pull request introduces 2 alerts when merging 43f8fb6 into 8c1ad08 - view on LGTM.com new alerts:
|
clepple
reviewed
Nov 8, 2020
Member
clepple
left a comment
clepple
left a comment
There was a problem hiding this comment.
No idea, but this driver has been around for a while, so I suspect someone would have noticed if the behavior was not correct.
Member
Author
|
New code wording does same logic as the old code did, but without warnings. If this did not explode in the years before so someone would complain, probably the logic is right indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered thanks to CI improvements from #844