Skip to content

Fightwarn fallthrough questionable - mge-xml #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimklimov merged 1 commit into from
Nov 11, 2020
Merged

Fightwarn fallthrough questionable - mge-xml #847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/mge-xml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,8 +1361,12 @@ static int mge_xml_startelm_cb(void *userdata, int parent, const char *nspace, c
state = XC_GENERAL;
break;
}
/* FIXME? Is the fall-through to handling "GENERAL" intended?
* was so in legacy code before the goto below... */
goto fallthrough_case_general;

case XC_GENERAL:
fallthrough_case_general:
if (!strcasecmp(name, "STARTUP")) {
/* config="CENTRALIZED" */
state = XC_STARTUP;
Expand Down