Fightwarn - sscanf signed vs unsigned#856
Merged
jimklimov merged 3 commits intonetworkupstools:masterfrom Nov 11, 2020
Merged
Conversation
…alues to fit into signed int
…values to fit into signed int
|
This pull request introduces 1 alert when merging f349ed8 into 8c1ad08 - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a number of data reads formatted as unsigned ints or hexes, written into signed variables with insufficient range for scanf'ing the potential size of unsigned original number. Commits in this PR aim to work around those situations.
Discovered thanks to CI improvements from #844