Skip to content

Fightwarn - unclassified fixes#858

Merged
jimklimov merged 15 commits intonetworkupstools:masterfrom
jimklimov:fightwarn-unclassified-fixes
Nov 11, 2020
Merged

Fightwarn - unclassified fixes#858
jimklimov merged 15 commits intonetworkupstools:masterfrom
jimklimov:fightwarn-unclassified-fixes

Conversation

@jimklimov
Copy link
Copy Markdown
Member

@jimklimov jimklimov commented Nov 8, 2020

Fixes to various small issues discovered thanks to CI improvements from #844

@jimklimov
drivers/rhino.c: ScanReceivePack(): rephrase if-clause to avoid warnings
cd6b77c 
Seems this is a correct change logically:
- if( !( SourceFail ) == RedeAnterior )
+ if( RedeAnterior == !( SourceFail ) )

given this assignment just below the if-clause:
  RedeAnterior = !( SourceFail );

to avoid a compiler warning that "!" might apply not in a way intended by author
@jimklimov
drivers/isbmex.c: comment about magic D() macro got debug logging vs.…
d895ed4 
… upsdebugx()
@jimklimov
drivers/solis.c: rectify C-style comments
06aec54
@jimklimov
drivers/solis.h: swap "const static" => "static const"
505c513 
Avoids error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
@jimklimov
drivers/libusb.c: fix debug string formatting
173d30d
@jimklimov
tools/nut-scanner/scan_xml_http.c: drop g_usec_timeout which is not a…
75de84d 
…ctually used
@jimklimov
drivers/hidparser.c: hide logging check that never fires
0a6a973 
hidparser.c:347:28: error: comparison is always false due
to limited range of data type [-Werror=type-limits]
  347 |  if(pParser->Data.ReportID >= MAX_REPORT)
uint8_t vs "500"

CC @aquette
@jimklimov
drivers/eaton-pdu-marlin-mib.c: sanity-check the outlet_group_nb (not…
b7bf472 
… negative)
@jimklimov
drivers/eaton-pdu-marlin-mib.c: rearrange phases_nb and sanity-check …
8808f9d 
…the value to debug-log unexpectancies
jimklimov
jimklimov commented Nov 8, 2020
View reviewed changes
Comment thread tools/nut-scanner/scan_xml_http.c
#ifdef HAVE_PTHREAD
static pthread_mutex_t dev_mutex;
#endif
long g_usec_timeout ;
Copy link
Copy Markdown
Member Author

@jimklimov jimklimov Nov 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aquette : was there any use or plan for this variable, or was it just some copy-paste artifact?

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Nov 8, 2020

This pull request introduces 2 alerts when merging 8808f9d into 8c1ad08 - view on LGTM.com

new alerts:

  • 2 for FIXME comment

@jimklimov jimklimov mentioned this pull request Nov 9, 2020
Open
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Nov 9, 2020

This pull request introduces 3 alerts when merging 6e98a25 into 8c1ad08 - view on LGTM.com

new alerts:

  • 3 for FIXME comment

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Nov 9, 2020

This pull request introduces 3 alerts and fixes 1 when merging 8e7f9d595f0115335962d94ed0c061e229cf731a into 8d2e761 - view on LGTM.com

new alerts:

  • 3 for FIXME comment

fixed alerts:

  • 1 for Comparison result is always the same

@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Nov 9, 2020

This pull request introduces 3 alerts and fixes 1 when merging 7e7a433d0929c340a08f4a72a3b8ed00a53fd961 into 8d2e761 - view on LGTM.com

new alerts:

  • 3 for FIXME comment

fixed alerts:

  • 1 for Comparison result is always the same

@jimklimov jimklimov force-pushed the fightwarn-unclassified-fixes branch from 7e7a433 to 1bc47ef Compare November 9, 2020 15:07
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Nov 9, 2020

This pull request introduces 3 alerts when merging 1bc47ef into 26c8994 - view on LGTM.com

new alerts:

  • 3 for FIXME comment

@jimklimov jimklimov merged commit 0b53180 into networkupstools:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clepple clepple Awaiting requested review from clepple

@aquette aquette Awaiting requested review from aquette

@msoltyspl msoltyspl Awaiting requested review from msoltyspl

@zykh zykh Awaiting requested review from zykh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jimklimov